Page MenuHomePhabricator
Create Task
Maniphest T326692

Reference previews should use Popups registration
Closed, ResolvedPublic
Actions

Description

Problem: Page previews and Reference Tooltips currently live in the same repository but are maintained by 2 different teams. The contract for how these interact is not clear and could be made clearer by separating code into two different folders.

Given the new architecture, the reference preview code should be separated from the page previews code and registered in the same way as the Math extension. On the long term it might make sense to move this out to another extension but this is not in scope for this ticket

TODO

Details

SubjectRepoBranchLines +/-
Reference previews should use Popups registrationmediawiki/extensions/Popupsmaster+400 -279
Reduce bundlesize of reference previews by making it use stable APIsmediawiki/extensions/Popupsmaster+53 -44
Generalize settings codemediawiki/extensions/Popupsmaster+197 -212
Model: Make dwell delay part of model and registrationmediawiki/extensions/Popupsmaster+65 -49
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Jan 10 2023, 11:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 10 2023, 11:28 PM
Jdlrobson updated the task description. (Show Details)Jan 10 2023, 11:30 PM
gerritbot added a comment.Jan 10 2023, 11:32 PM

Change 878215 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Popups@master] WIP: Reference previews should use Popups registration

https://gerrit.wikimedia.org/r/878215

gerritbot added a project: Patch-For-Review.Jan 10 2023, 11:32 PM
Jdlrobson added a project: Web-Team-Backlog (Needs Prioritization (Tech)).Jan 12 2023, 10:02 PM
Jdlrobson moved this task from Backlog to Page previews maintenance on the Web-Team-Backlog (Needs Prioritization (Tech)) board.
GMikesell-WMF mentioned this in T326415: Add (show IP) buttons next to temporary account user name links.Feb 9 2023, 11:30 PM
Jdlrobson triaged this task as Low priority.Mar 15 2023, 9:30 PM
gerritbot added a comment.Mar 22 2023, 12:25 AM

Change 859574 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Popups@master] [WIp] Generalize settings code

https://gerrit.wikimedia.org/r/859574

gerritbot added a comment.May 17 2023, 12:54 AM

Change 902134 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Popups@master] Model: Make dwell delay part of model and registration

https://gerrit.wikimedia.org/r/902134

Jdlrobson updated the task description. (Show Details)May 25 2023, 7:40 PM
gerritbot added a comment.Jul 27 2023, 1:33 PM

Change 902134 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Model: Make dwell delay part of model and registration

https://gerrit.wikimedia.org/r/902134

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.20; 2023-08-01).Jul 27 2023, 2:00 PM
Jdlrobson mentioned this in T345261: Build popup setting dialog with OOUI elements.Sep 5 2023, 10:09 PM
Jdlrobson mentioned this in T345781: Reference preview settings cog doesn't do anything when clicked.Sep 6 2023, 9:49 PM
gerritbot added a comment.Oct 17 2023, 3:42 PM

Change 859574 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Generalize settings code

https://gerrit.wikimedia.org/r/859574

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.2; 2023-10-24).Oct 17 2023, 4:00 PM
gerritbot added a comment.Nov 10 2023, 1:29 AM

Change 967306 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Popups@master] Generalize settings code (attempt 2)

https://gerrit.wikimedia.org/r/967306

Jdlrobson raised the priority of this task from Low to Medium.Jan 8 2024, 10:45 PM
Jdlrobson moved this task from Page previews maintenance to Tracking Indefinitely on the Web-Team-Backlog (Needs Prioritization (Tech)) board.
Jdlrobson moved this task from Tracking Indefinitely to Backlog on the Web-Team-Backlog (Needs Prioritization (Tech)) board.
ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.14; 2024-01-16); removed MW-1.42-notes (1.42.0-wmf.2; 2023-10-24).Jan 10 2024, 1:00 PM
gerritbot added a comment.Jan 11 2024, 10:28 PM

Change 989961 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Popups@master] [POC] Reduce bundlesize of reference previews by making it use stable APIs

https://gerrit.wikimedia.org/r/989961

Jdlrobson moved this task from Backlog to Tracking (Temporarily) on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Jan 11 2024, 10:29 PM
Jdlrobson added a subscriber: awight.

@awight could your team please review https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Popups/+/878215 before making further changes to the codebase (specifically significant changes that would lead to hard to resolve merge conflicts)? This should help with the long term plan we discussed of moving this code to the Cite extension. (Note https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Popups/+/989889 is currently a blocker for any changes being merged to Popups extensions)

Jdlrobson mentioned this in T353798: Fix the data collection for ReferencePreviews.Jan 11 2024, 10:31 PM
gerritbot added a comment.Jan 12 2024, 10:31 PM

Change 990256 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Cite@master] WIP: Move reference previews to Cite extension

https://gerrit.wikimedia.org/r/990256

gerritbot added a comment.Jan 12 2024, 10:31 PM

Change 990257 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Popups@master] Drop reference previews from Popups, move to Cite

https://gerrit.wikimedia.org/r/990257

Jdlrobson assigned this task to awight.Jan 12 2024, 10:45 PM

Let me know if a meeting would help! T326692#9454918

gerritbot added a comment.Jan 16 2024, 3:45 PM

Change 878215 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Reference previews should use Popups registration

https://gerrit.wikimedia.org/r/878215

gerritbot added a comment.Jan 16 2024, 3:45 PM

Change 989961 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Reduce bundlesize of reference previews by making it use stable APIs

https://gerrit.wikimedia.org/r/989961

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.15; 2024-01-23); removed MW-1.42-notes (1.42.0-wmf.14; 2024-01-16).Jan 16 2024, 4:00 PM
Jdlrobson updated the task description. (Show Details)Jan 16 2024, 9:00 PM
Jdlrobson closed this task as Resolved.Jan 16 2024, 11:55 PM
Jdlrobson mentioned this in T355194: Move the reference previews code to Cite extension.

To be continued in T355194

awight removed awight as the assignee of this task.Jan 17 2024, 9:42 AM
awight added a project: WMDE-TechWish-Sprint-2024-01-17.
awight moved this task from Sprint Backlog to Watching / Epic / Stalled on the WMDE-TechWish-Sprint-2024-01-17 board.
Jdlrobson edited projects, added Reference Previews; removed Web-Team-Backlog (Needs Prioritization (Tech)).Jan 30 2024, 10:25 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL