| lilients_WMDE | |
| Aug 30 2023, 2:45 PM |
| F37658930: Screenshot 2023-09-05 at 3.11.09 PM.png | |
| Sep 5 2023, 10:11 PM |
To enable all the nice accessibility features provided by OOUI element in the setting dialog and the setting button, we should use them! (See parent ticket for screenshots)
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| [WIP] Use button widget for reference settings button | mediawiki/extensions/Popups | master | +43 -27 K |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T338318 Evaluate & improve accessibility of TechWish products | |||
| Open | None | T339230 Evaluate & improve accessibility of Reference Previews | |||
| Open | None | T339912 Fix accessibility issues in reference preview settings dialog | |||
| Declined | None | T345261 Build popup setting dialog with OOUI elements |
Hey @Jdlrobson we're half-randomly working on some a11y improvements around projects we worked on and parts of the Page-Previews project came to our attention. It's a wide area of thing that could be done there but we found this - kind of - clear and hopefully uncontroversial part. The question is, if it's desirable to add OOUI to this extension in the first place.
Thanks in advance for your feedback. :-)
Change 954303 had a related patch set uploaded (by Svantje Lilienthal; author: Svantje Lilienthal):
[mediawiki/extensions/Popups@master] [WIP] Use button widget for reference settings button
@WMDE-Fisch hey there thanks for reaching out. I've actually been trying to get a hold of someone in WMDE regarding reference previews - in particular settings - for a long time so maybe you can help me with that (I've cc'ed you on the email chain)!
The Math extension has a preview that is currently not configurable (T334261). To fix this we've been hoping to generalize our approach to settings in the extension and that's been blocked on finding someone to review https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Popups/+/859574 who is familiar with Reference Tooltips.
On the long term we'd like help with pulling Reference Previews out into its own extension (T326692) or at least into its own module/folder so it's clearer what is the responsibility of WMDE and what is considered architecture and a responsibility of the web team (accessibility of the settings dialog seems like something the web team should be responsible/accountable for). Are these tasks you'd be able to help us with?
On the subject of adding OOUI to Popups, this is not desirable. The web team has been moving towards Codex and away from OOUI in all of it's projects and is planning on revisiting how the settings work for page previews. We're beginning that work next week as part of T345363. The goal (T233741) is to eventually ship a standardized tool for modifying device specific preferences to all skins inside MediaWiki core and for Popups to make use of this.
Hope this clears things up? I'd be happy to dive into more details about the bigger picture with you if needed.
Also is the references setting icon currently broken? When visting https://en.wikipedia.beta.wmflabs.org/wiki/Spain#cite_note-roth-3 clicking on the cog in this preview seems to do nothing?
Change 954303 abandoned by Thiemo Kreuz (WMDE):
[mediawiki/extensions/Popups@master] [WIP] Use button widget for reference settings button
Reason:
See T345261#9144316.
Thanks, that makes sense. I think we briefly talked about this back then when the Reference Previews feature was added and came to the same conclusion. Let's not move the code in the wrong direction.
I created T345829 for the unrelated issue.