Page MenuHomePhabricator

SX: Edit translation button doesn't work for lead sections
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  1. Open Section Translation in test wiki (or any other wiki with SX enabled)
  2. Select a new page to create, by translating the lead section
  3. Proceed to the "Pick a sentence" step, select a sentence and click on "Edit translation" button

What happens?:
The Visual Editor doesn't open, because an error has occurred.

What should have happened instead?:
The Visual Editor should appear properly and no error should occur

Other information (browser name/version, screenshots, etc.):
Screencast from test wiki:

Event Timeline

Change 880482 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX: Use optional chaining for current target page title

https://gerrit.wikimedia.org/r/880482

Change 880482 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX: Use optional chaining for current target page title

https://gerrit.wikimedia.org/r/880482

Change 880497 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20230117

https://gerrit.wikimedia.org/r/880497

Change 880497 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20230117

https://gerrit.wikimedia.org/r/880497

Test status: QA PASS

Edit translation button works as expected

Pginer-WMF subscribed.

Test status: QA PASS

Edit translation button works as expected

@EChukwukere-WMF the video you sharted shows how the button works for a translation that is expanding the article with a new section. However, the ticket is about a different usecase: starting a new article by translating an article that does not exist in the target language. Notice that the video in the description is translating the article to Igbo a language for which the selected article does not exist.

@Pginer-WMF yes you are right. It does work as well for article with no pre existing translations. See below:

Perfect. Thanks @EChukwukere-WMF for verifying