Page MenuHomePhabricator
Create Task
Maniphest T327505

Site notice for Vector 2022 is sometimes not possible to dismiss
Closed, ResolvedPublic
Actions

Description

image.png (1×2 px, 645 KB)

Apologies for being unable to exactly state the steps to reproduce, but I've noticed the following on en.wikipedia.org in private browsing with Firefox 110:

  • sometimes, clicking the X button any number of times will not dismiss the site notice
  • clicking through to the link for "We've made a few changes", going back, and clicking the X sometimes does not dismiss the site notice
  • sometimes 2 or more clicks to the X button will close the notice

In the above scenarios, I do not see any JS console errors.

Tagging with Vector 2022 for awareness, since that project has an active site notice, but I can also reproduce this issue with ?useskin=vector. I'm not sure what other project tags to use for site notices.

Event Timeline

kostajh created this task.Jan 20 2023, 2:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 20 2023, 2:20 PM
kostajh added a project: MediaWiki-extensions-CentralNotice.Jan 20 2023, 2:23 PM
AndyRussG added a project: Fundraising-Backlog.Jan 20 2023, 4:37 PM
spatton added subscribers: sgrabarczuk, spatton.Jan 20 2023, 5:01 PM

My javascript isn't great so someone else should review this but in case it's helpful: I saw this task, investigated a little and can replicate click issues for this banner in any browser I try (chrome, firefox, safari). I think it's due to the onclick event that hides the banner happening on the cbnnr-close-icon element, rather than its container; you can't actually click the blue circular padding on the close icon, so you have to be right on top of the X for the click to register.

Could this be what you're experiencing, @kostajh?

Tagging @sgrabarczuk as I see him in the CentralNotice logs as having worked on the banner.

Pcoombe closed this task as Resolved.Jan 20 2023, 6:08 PM
Pcoombe claimed this task.
Pcoombe subscribed.

Thanks @spatton, that definitely looks like the issue! I moved the onclick to the close element, and also changed it to an <a> tag for better accessibility. In banner preview it appears to be fixed.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits