Page MenuHomePhabricator
Create Task
Maniphest T328039

Ensure mobile New Topic Tool opens above the "Add topic" button
Closed, ResolvedPublic
Actions

Description

Behavior

  1. Visit a mobile talk page where the suite of DiscussionTools is enabled. E.g. https://fr.m.wikipedia.org/wiki/Discussion:Citron .
  2. Tap the Add topic button that appears at the bottom of the page

Actual

  1. ❗️ The New Topic Tool appears BENEATH the Add topic button:

Screen Shot 2023-01-26 at 8.24.57 AM.png (1×720 px, 89 KB)

Expected

  1. ✅ The New Topic Tool appears ABOVE the Add topic button

Details

SubjectRepoBranchLines +/-
NewTopicController: Attach after .mw-parser-outputmediawiki/extensions/DiscussionToolsmaster+12 -1
Customize query in gerrit

Event Timeline

ppelberg created this task.Jan 26 2023, 4:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 26 2023, 4:25 PM
VPuffetMichel moved this task from Backlog to Triaged on the DiscussionTools board.Jan 26 2023, 4:25 PM
ppelberg edited projects, added Editing-team (Kanban Board); removed Editing-team.Jan 26 2023, 7:38 PM
ppelberg updated the task description. (Show Details)
matmarex claimed this task.Feb 1 2023, 4:35 PM
ppelberg moved this task from Incoming to Ready to Be Worked On on the Editing-team (Kanban Board) board.Feb 1 2023, 4:36 PM
gerritbot added a comment.Feb 1 2023, 6:51 PM

Change 885855 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] NewTopicController: Attach after .mw-parser-output

https://gerrit.wikimedia.org/r/885855

gerritbot added a project: Patch-For-Review.Feb 1 2023, 6:51 PM
matmarex moved this task from Ready to Be Worked On to Code Review on the Editing-team (Kanban Board) board.Feb 1 2023, 6:52 PM
gerritbot added a comment.Feb 2 2023, 12:09 PM

Change 885855 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] NewTopicController: Attach after .mw-parser-output

https://gerrit.wikimedia.org/r/885855

Maintenance_bot removed a project: Patch-For-Review.Feb 2 2023, 12:31 PM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.22; 2023-02-06).Feb 2 2023, 1:00 PM
matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Feb 2 2023, 4:49 PM
matmarex added a project: Editing QA.
EAkinloose edited projects, added Verified; removed Editing QA.Feb 9 2023, 6:26 PM
EAkinloose subscribed.

Tested on https://simple.wikipedia.beta.wmflabs.org/

Screenshot 2023-02-09 at 19.20.13.png (1×712 px, 119 KB)

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Feb 9 2023, 6:27 PM
ppelberg closed this task as Resolved.Feb 9 2023, 6:51 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits