| matmarex | |
| Jan 27 2023, 12:07 AM |
| F36863291: image.png | |
| Feb 21 2023, 3:47 AM |
| F36863288: image.png | |
| Feb 21 2023, 3:47 AM |
| F36824369: image.png | |
| Feb 13 2023, 9:54 PM |
| F36524466: image.png | |
| Jan 27 2023, 12:07 AM |
https://logstash.wikimedia.org/goto/1567c2583e8688288ad17e856d378116
These errors shouldn't be possible, we should add detailed error logging to see what values it's trying to construct URLs with.
Change 884268 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Error logging for native URL errors
Patch is merging; we'll want to wait for this to roll out on the train and then for logging to actually happen, I assume.
Change 884268 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Error logging for native URL errors
Query for the new error logging: https://logstash.wikimedia.org/goto/c9fceba5da8bb2545325653fe934c498
Errors are either URL error when parsing value: "" or URL error when parsing value: undefined.
I found a way to trigger URL error when parsing value: undefined: when DiscussionTools is disabled, 2017WTE is enabled, and you click "Add topic" (not in Vector sticky header) on a page where VE is also available. Somehow I don't think that's a common situation… but let's start with that.
Change 888801 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] DesktopArticleTarget.init: Fix init from "Add topic" tab in some cases
I think most of these errors are caused by gadgets that add things indistinguishable from section edit links. For example (assuming again that DiscussionTools is disabled, 2017WTE is enabled), the error logging triggers on https://meta.wikimedia.org/wiki/Community_Wishlist_Survey/Sandbox when clicking the "Add topic" link added to the last section by the gadget https://meta.wikimedia.org/wiki/MediaWiki:Gadget-AddTopic.js:
We should probably just ignore empty/undefined targets on these links.
Change 888805 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] DesktopArticleTarget.init: Ignore fake section edit links added by gadgets
Change 888801 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] DesktopArticleTarget.init: Fix init from "Add topic" tab in some cases
Change 888805 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] DesktopArticleTarget.init: Ignore fake section edit links added by gadgets
Looks fixed:
https://logstash.wikimedia.org/goto/1567c2583e8688288ad17e856d378116
https://logstash.wikimedia.org/goto/c9fceba5da8bb2545325653fe934c498
The remaining small trickle of errors seems unrelated to our code.