Test failures under PHPUnit 9.6: "Expecting E_DEPRECATED and E_USER_DEPRECATED is deprecated and will no longer be possible in PHPUnit 10"
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	xSavitar
	Feb 3 2023, 9:42 AM

Description

Current status: Mitigated by pinning PHPUnit 9.5.x; task remains open so we can figure out how to properly resolve this and update to PHPUnit 9.6. (PHPUnit 10 drops support for PHP ≤8.0, so we won’t be able to update to that too soon.)

CI is failing with the following error/warning (example build):

11:26:00 There were 42 warnings:
11:26:00 
11:26:00 1) DeprecatedGlobalTest::testWarning
11:26:00 Expecting E_DEPRECATED and E_USER_DEPRECATED is deprecated and will no longer be possible in PHPUnit 10.
11:26:00 
11:26:00 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
11:26:00 
11:26:00 2) MediaWiki\HookContainer\HookContainerTest::testEmitDeprecationWarnings
11:26:00 Expecting E_DEPRECATED and E_USER_DEPRECATED is deprecated and will no longer be possible in PHPUnit 10.
11:26:00 
11:26:00 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
11:26:00 
11:26:00 3) MediaWiki\Tests\Unit\Revision\MutableRevisionRecordTest::testGetIdTriggerDeprecatedWarning
11:26:00 Expecting E_DEPRECATED and E_USER_DEPRECATED is deprecated and will no longer be possible in PHPUnit 10.
11:26:00 
11:26:00 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
11:26:00 
11:26:00 4) MediaWiki\Tests\Unit\Revision\MutableRevisionRecordTest::testGetPageIdTriggerDeprecatedWarning
11:26:00 Expecting E_DEPRECATED and E_USER_DEPRECATED is deprecated and will no longer be possible in PHPUnit 10.
11:26:00 
11:26:00 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
11:26:00 
11:26:00 5) MediaWiki\Tests\Unit\Revision\MutableRevisionRecordTest::testGetParentIdTriggerDeprecatedWarning
11:26:00 Expecting E_DEPRECATED and E_USER_DEPRECATED is deprecated and will no longer be possible in PHPUnit 10.
11:26:00 
11:26:00 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
11:26:00 
11:26:00 6) MediaWiki\Tests\Unit\Revision\RevisionArchiveRecordTest::testGetIdTriggerDeprecatedWarning
11:26:00 Expecting E_DEPRECATED and E_USER_DEPRECATED is deprecated and will no longer be possible in PHPUnit 10.
11:26:00 
11:26:00 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
11:26:00 
11:26:00 7) MediaWiki\Tests\Unit\Revision\RevisionArchiveRecordTest::testGetPageIdTriggerDeprecatedWarning
11:26:00 Expecting E_DEPRECATED and E_USER_DEPRECATED is deprecated and will no longer be possible in PHPUnit 10.
11:26:00 
11:26:00 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
11:26:00 
11:26:00 8) MediaWiki\Tests\Unit\Revision\RevisionArchiveRecordTest::testGetParentIdTriggerDeprecatedWarning
11:26:00 Expecting E_DEPRECATED and E_USER_DEPRECATED is deprecated and will no longer be possible in PHPUnit 10.
11:26:00 
11:26:00 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
11:26:00 
11:26:00 9) MediaWiki\Tests\Unit\Revision\RevisionStoreCacheRecordTest::testGetIdTriggerDeprecatedWarning
11:26:00 Expecting E_DEPRECATED and E_USER_DEPRECATED is deprecated and will no longer be possible in PHPUnit 10.
11:26:00 
11:26:00 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
11:26:00 
11:26:00 10) MediaWiki\Tests\Unit\Revision\RevisionStoreCacheRecordTest::testGetPageIdTriggerDeprecatedWarning
11:26:00 Expecting E_DEPRECATED and E_USER_DEPRECATED is deprecated and will no longer be possible in PHPUnit 10.
11:26:00 
11:26:00 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
11:26:00 
11:26:00 11) MediaWiki\Tests\Unit\Revision\RevisionStoreCacheRecordTest::testGetParentIdTriggerDeprecatedWarning
11:26:00 Expecting E_DEPRECATED and E_USER_DEPRECATED is deprecated and will no longer be possible in PHPUnit 10.
11:26:00 
11:26:00 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
11:26:00 
11:26:00 12) MediaWiki\Tests\Unit\Revision\RevisionStoreRecordTest::testGetIdTriggerDeprecatedWarning
11:26:00 Expecting E_DEPRECATED and E_USER_DEPRECATED is deprecated and will no longer be possible in PHPUnit 10.

Some affected patches: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/884414 & https://gerrit.wikimedia.org/r/c/mediawiki/core/+/884065.

Details

Subject	Repo	Branch	Lines +/-
Update OOUI to v0.47.0	mediawiki/core	master	+967 -272
releases: Pin PHPUnit to 9.5.28 (latest 9.5.x as of today)	labs/libraryupgrader/config	master	+23 -0
Make Tag methods fail the same way in PHP before and after 8.1	oojs/ui	master	+10 -7
Pin PHPUnit to 9.5.x	mediawiki/core	wmf/1.40.0-wmf.21	+1 -1
Pin PHPUnit to 9.5.x	mediawiki/core	master	+1 -1
DNM: Empty change to test CI	mediawiki/extensions/Wikibase	master	+0 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Stalled	None	T255792 Quibble runs core:unit tests twice!
Open	None	T328919 Upgrade to PHPUnit 10
Resolved	Lucas_Werkmeister_WMDE	T328741 Test failures under PHPUnit 9.6: "Expecting E_DEPRECATED and E_USER_DEPRECATED is deprecated and will no longer be possible in PHPUnit 10"

Event Timeline

xSavitar created this task.Feb 3 2023, 9:42 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 3 2023, 9:42 AM

xSavitar updated the task description. (Show Details)Feb 3 2023, 9:43 AM

xSavitar updated the task description. (Show Details)

Also affects Wikibase, so shared CI blocker ⇒ UBN. I suspect we need to pin PHPUnit to 9.5, since 9.6 and 10 (both released today) are effectively both breaking changes, regardless of the major/minor version change.

Change 886324 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/core@master] Pin PHPUnit to 9.5.x

https://gerrit.wikimedia.org/r/886324

gerritbot added a project: Patch-For-Review.Feb 3 2023, 9:57 AM

Let’s see if that works.

Michael subscribed.Feb 3 2023, 9:59 AM

Change 886325 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] DNM: Empty change to test CI

https://gerrit.wikimedia.org/r/886325

Change 886325 abandoned by Lucas Werkmeister (WMDE):

[mediawiki/extensions/Wikibase@master] DNM: Empty change to test CI

Reason:

https://gerrit.wikimedia.org/r/886325

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Feb 3 2023, 10:28 AM

Change 886324 merged by jenkins-bot:

[mediawiki/core@master] Pin PHPUnit to 9.5.x

https://gerrit.wikimedia.org/r/886324

Lucas_Werkmeister_WMDE renamed this task from Expecting E_DEPRECATED and E_USER_DEPRECATED is deprecated and will no longer be possible in PHPUnit 10 to Test failures under PHPUnit 9.6: "Expecting E_DEPRECATED and E_USER_DEPRECATED is deprecated and will no longer be possible in PHPUnit 10".Feb 3 2023, 10:35 AM

Lucas_Werkmeister_WMDE lowered the priority of this task from Unbreak Now! to Needs Triage.

Lucas_Werkmeister_WMDE updated the task description. (Show Details)

As far as I can tell, the only solution is to stop using the expectDeprecation, expectNotice, expectWarning and expectError methods on TestCase. I don’t see any way to filter the warning in the PHPUnit 9.6 code. There is also no PHPUnit replacement for these expectations (source):

There are no replacements. PHPUnit 10 no longer converts E_* to exceptions, therefore E_* can no longer be expected.

Does that mean we also need to stop using trigger_error() in our non-test code (e.g. MWDebug::sendRawDeprecated())? Or can we create our own way to to test this behavior?

Lucas_Werkmeister_WMDE added projects: MediaWiki-Core-Tests, Math.Feb 3 2023, 10:42 AM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.22; 2023-02-06).Feb 3 2023, 11:00 AM

Maintenance_bot removed a project: Patch-For-Review.Feb 3 2023, 11:30 AM

I guess we should probably pin to 9.5.x in all the repos and branches, as mitigation for now? https://codesearch-beta.wmcloud.org/search/?q=%22phpunit%2Fphpunit%22%3A+%22%5C%5E9.5%22&files=composer%5C.json&excludeFiles=&repos=

Maybe? Though not a lot of repositories use the deprecated expects methods, it seems.

Change 886364 had a related patch set uploaded (by Jforrester; author: Jforrester):

[labs/libraryupgrader/config@master] releases: Pin PHPUnit to 9.5.28 (latest 9.5.x as of today)

https://gerrit.wikimedia.org/r/886364

gerritbot added a project: Patch-For-Review.Feb 3 2023, 2:24 PM

In T328741#8585355, @Lucas_Werkmeister_WMDE wrote:

Maybe? Though not a lot of repositories use the deprecated expects methods, it seems.

Ack. We probably should have been pinning this earlier anyway, like we do for other CI-critical repos.

Lucas_Werkmeister_WMDE added a parent task: T328919: Upgrade to PHPUnit 10.Feb 6 2023, 2:50 PM

Change 886906 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[oojs/ui@master] Make Tag methods throw proper exceptions instead of warnings

https://gerrit.wikimedia.org/r/886906

Change 886981 had a related patch set uploaded (by Bartosz Dziewoński; author: Lucas Werkmeister (WMDE)):

[mediawiki/core@wmf/1.40.0-wmf.21] Pin PHPUnit to 9.5.x

https://gerrit.wikimedia.org/r/886981

Change 886981 merged by jenkins-bot:

[mediawiki/core@wmf/1.40.0-wmf.21] Pin PHPUnit to 9.5.x

https://gerrit.wikimedia.org/r/886981

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.21; 2023-01-30); removed MW-1.40-notes (1.40.0-wmf.22; 2023-02-06).Feb 7 2023, 4:00 PM

Change 886906 merged by jenkins-bot:

[oojs/ui@master] Make Tag methods fail the same way in PHP before and after 8.1

https://gerrit.wikimedia.org/r/886906

Change 886364 merged by jenkins-bot:

[labs/libraryupgrader/config@master] releases: Pin PHPUnit to 9.5.28 (latest 9.5.x as of today)

https://gerrit.wikimedia.org/r/886364

Maintenance_bot removed a project: Patch-For-Review.Feb 21 2023, 3:10 AM

OK, provisionally this should be avoided everywhere now except a handful of repos that are waiting to update from 8|9 to just a pinned 9.5.28.

I thought we were keeping this task open to figure out how to properly solve the issue… unless we’re fine wtih skipping PHPUnit 9.6 and going straight to 10, which we already have a task for?

In T328741#8633107, @Lucas_Werkmeister_WMDE wrote:

I thought we were keeping this task open to figure out how to properly solve the issue… unless we’re fine wtih skipping PHPUnit 9.6 and going straight to 10, which we already have a task for?

I think that's fine (especially as PHPUnit 10 won't be for ~5 years).

Change 921070 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] Update OOUI to v0.47.0

https://gerrit.wikimedia.org/r/921070

gerritbot added a project: Patch-For-Review.May 18 2023, 5:16 PM

Change 921070 merged by jenkins-bot:

[mediawiki/core@master] Update OOUI to v0.47.0

https://gerrit.wikimedia.org/r/921070

Maintenance_bot removed a project: Patch-For-Review.May 18 2023, 8:31 PM