Page MenuHomePhabricator
Create Task
Maniphest T332697

Visual diff: List markers should be greyed out unless the whole list item was removed/inserted/moved
Closed, ResolvedPublic
Actions

Description

In this example:

image.png (113×142 px, 3 KB)

item 2 should be greyed out

Details

SubjectRepoBranchLines +/-
Vector: Use greyed out version of bullet image in visual diffsmediawiki/extensions/VisualEditormaster+22 -0
Update VE core submodule to master (e180b2f94)mediawiki/extensions/VisualEditormaster+1 -1
Suppress list-style-image in diff list spacerVisualEditor/VisualEditormaster+1 -0
Grey out list marker when list item is no-change contextVisualEditor/VisualEditormaster+46 -26
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Mar 21 2023, 1:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 21 2023, 1:34 PM
Esanders updated the task description. (Show Details)Mar 21 2023, 1:50 PM
gerritbot added a comment.Mar 21 2023, 2:32 PM

Change 901597 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Grey out list marker when list item is no-change context

https://gerrit.wikimedia.org/r/901597

gerritbot added a project: Patch-For-Review.Mar 21 2023, 2:32 PM
Esanders moved this task from Backlog to In progress on the VisualEditor-VisualDiffs board.Mar 21 2023, 2:32 PM
Esanders mentioned this in T319179: Visual diffs of lists shouldn't render the entire list.Mar 21 2023, 2:42 PM
matmarex added a project: Editing-team (Kanban Board).Mar 22 2023, 10:16 PM
matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
matmarex moved this task from To Triage to Triaged on the VisualEditor board.
matmarex subscribed.Mar 23 2023, 7:21 PM
gerritbot added a comment.Mar 23 2023, 7:23 PM

Change 901597 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Grey out list marker when list item is no-change context

https://gerrit.wikimedia.org/r/901597

matmarex moved this task from Code Review to Blocked / Needs More Work on the Editing-team (Kanban Board) board.Mar 23 2023, 7:30 PM

This takes care of numbered lists, but not bulleted lists, because the bullet icon is an image (at least on Vector).

Maintenance_bot removed a project: Patch-For-Review.Mar 23 2023, 7:30 PM
Esanders moved this task from Blocked / Needs More Work to Ready to Be Worked On on the Editing-team (Kanban Board) board.Mar 27 2023, 5:12 PM
gerritbot added a comment.Mar 28 2023, 11:16 AM

Change 903624 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Suppress list-style-image in diff list spacer

https://gerrit.wikimedia.org/r/903624

gerritbot added a project: Patch-For-Review.Mar 28 2023, 11:16 AM

Change 903625 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Vector: Use greyed out version of bullet image in visual diffs

https://gerrit.wikimedia.org/r/903625

Esanders added a comment.Mar 28 2023, 11:18 AM

Fixed in Vector with the above 2 patches:

image.png (153×383 px, 12 KB)

Esanders moved this task from Ready to Be Worked On to Code Review on the Editing-team (Kanban Board) board.Mar 28 2023, 11:18 AM
gerritbot added a comment.Mar 28 2023, 10:49 PM

Change 903624 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Suppress list-style-image in diff list spacer

https://gerrit.wikimedia.org/r/903624

gerritbot added a comment.Mar 28 2023, 11:02 PM

Change 903790 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (e180b2f94)

https://gerrit.wikimedia.org/r/903790

gerritbot added a comment.Mar 28 2023, 11:18 PM

Change 903790 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (e180b2f94)

https://gerrit.wikimedia.org/r/903790

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.3; 2023-04-03).Mar 29 2023, 12:00 AM
gerritbot added a comment.Mar 29 2023, 7:25 PM

Change 903625 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Vector: Use greyed out version of bullet image in visual diffs

https://gerrit.wikimedia.org/r/903625

Maintenance_bot removed a project: Patch-For-Review.Mar 29 2023, 7:30 PM
matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Mar 29 2023, 7:36 PM
matmarex added a project: Editing QA.
EAkinloose subscribed.Apr 4 2023, 5:07 PM

✅ List markers are greyed out as expected

Screenshot 2023-04-04 at 17.44.35.png (444×734 px, 19 KB)

EAkinloose closed this task as Resolved.Apr 4 2023, 5:07 PM
EAkinloose claimed this task.
EAkinloose removed a project: Editing QA.
EAkinloose added a project: Verified.Apr 5 2023, 7:06 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL