Page MenuHomePhabricator

Visual diffs of lists shouldn't render the entire list
Closed, ResolvedPublic

Description

I looked at this diff today, which is a reply to the 133rd item in a list. Instead of simply showing that list item and the response, the visual diff has rendered the entire section, resulting in a large amount of scrolling before I could find the actual change.

I'm not sure what the exact issue is here, but I assume it relates to lists.

Event Timeline

Esanders subscribed.

Tagging DT as many large lists are on talk pages.

Change 895840 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Collapse no-change diff context in lists

https://gerrit.wikimedia.org/r/895840

Change 895840 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Collapse no-change diff context in lists

https://gerrit.wikimedia.org/r/895840

Change 896187 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7e95f6c58)

https://gerrit.wikimedia.org/r/896187

Change 896187 merged by DLynch:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7e95f6c58)

https://gerrit.wikimedia.org/r/896187

The "133." in that example should be grey and will be fixed in T332697

matmarex edited projects, added Skipped QA; removed Editing QA, Editing-team (Kanban Board).

I've been using the visual diff mode to follow changes on talk pages recently (inclusing the infamous Vector RFC) and this change is honestly the best thing since we invented the reply tool ;) I think we can close this task, it works great.

For reference, here's how the diff in the task description looks like today, and how it would have looked before:

nice.png (1×1 px, 202 KB)
myeyessssss.png (14×953 px, 3 MB)
matmarex assigned this task to Esanders.