Page MenuHomePhabricator

When viewing the transcoding status in non-English, the intonation becomes strange and English appears
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

已完成于08:58, 26 December 2018

What should have happened instead?:

已于2018年12月26日08:58完成

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

The qqx string is timedmedia-completed-on: 09:26, 26 December 2018

The qqx string is timedmedia-completed-on: 09:26, 26 December 2018

So can we change the QQX string to 2022-02-22, 22:22 format?

In T333789#8774360, @I wrote:

The qqx string is timedmedia-completed-on: 09:26, 26 December 2018

So can we change the QQX string to 2022-02-22, 22:22 format?

Thats not the problem, it just identifies where to fix it. The problem here is that the timestamp is not being localised before being fed to the localised version of the interface message (which is how history pages etc do it). This definitely can be fixed, but TimedMediaHandler doesn't have paid developers working on it, so it might take some time before it is picked up.

Umherirrender subscribed.

The timestamp is formatted by the content language (since it was added in fbcb34bf2c09ef74c44b00830c9d011b56318d6e)

But other parts are formatted using user language, so it seems valid to change

Change 909333 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/TimedMediaHandler@master] TranscodeStatusTable: Format timestamp in user language

https://gerrit.wikimedia.org/r/909333

@I Is this correct ?

Screenshot 2023-04-17 at 21.33.23.png (712×1 px, 205 KB)

This is the case, but you are using the traditional Chinese version, but the simplified Chinese and zh-CN version did not fix.

I changed the task status from Open to In Progress.Apr 18 2023, 5:45 AM

Change 909333 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] TranscodeStatusTable: Format timestamp in user language

https://gerrit.wikimedia.org/r/909333

In T333789#8788141, @I wrote:

@I Is this correct ?

Screenshot 2023-04-17 at 21.33.23.png (712×1 px, 205 KB)

This is the case, but you are using the traditional Chinese version, but the simplified Chinese and zh-CN version did not fix.

The code is using the same functions for date/time as other dates, so the user lang from preferences or uselang parameter should be used now. This includes variants.
Lets see when it is on wmf wikis, if there are still issues feel free to reopen or create a new one.

Sorry, so far this problem still exists. Let's open this task again for a while.

Screenshot_2023-04-23-18-59-26-26_40deb401b9ffe8e1df2f1cc5ba480b12.jpg (1×1 px, 470 KB)

@I: The patch is merged and will be deployed in the next days. Please do not change task status and do not add random tags to tasks.

No longer english month names on that page, looks good to me.