Page MenuHomePhabricator

Regression: <includeonly>subst:</includeonly> is not parsed when viewing in an edit notice
Closed, InvalidPublic

Description

Trying for example create an new Featured picture candidate on commons, the edit intro usually shows what code should be entered on the list page, for example Trying to create an nomination of image called 'Testing.jpg' you'll be redirected to edit page:

http://commons.wikimedia.org/w/index.php?action=edit&preload=Template%3AFPCnomNewerPreload&editintro=Template%3AFPCnomNewInstructions&summary=&nosummary=&prefix=&minor=&title=Commons%3AFeatured+picture+candidates%2FFile%3ATesting.jpg&create=Create+new+nomination

The edit intro now says '{{{{subst:FULLPAGENAME}}}}', last week it would say '{{Commons:Featured picture candidates/File:Testing.jpg}}' instead.


Version: 1.18.x
Severity: normal

Details

Reference
bz31395

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 21 2014, 11:47 PM
bzimport set Reference to bz31395.
bzimport added a subscriber: Unknown Object (MLST).
AzaToth created this task.Oct 5 2011, 9:54 PM

I've noticed that the magic word {{REVISIONUSER}} renders as a blank string when placed in an edit notice. This sounds suspiciously like the same bug.

(In reply to comment #0)

The edit intro now says '{{{{subst:FULLPAGENAME}}}}', last week it would say
'{{Commons:Featured picture candidates/File:Testing.jpg}}' instead.

I saw that it was indeed litterally saying "subst:FULLPAGENAME" instead of the actual page name. However, to my knowledge, it was never supposed to show the full page name there. If under 1.17 edit notice showed the full pagename there, then that was a bug. Because in templates and all other transclusions, subst: is only parsed when saved, not via <includeonly>.

The behavior were trying to simulate has been implemented a few years ago as "safesubst:".

However, when looking at Template:FPCnomNewInstructions again, I don't see why you need any of the complicated <includeonly> and subst: for FULLPAGENAME. It can simply just be {{FULLPAGENAME}}.

Edited: http://commons.wikimedia.org/w/index.php?title=Template:FPCnomNewInstructions&diff=prev&oldid=60608306

Marking INVALID as this was a fixed bug in inconsistency between the editnotice parser and the regular parser, not a regression.

(In reply to comment #1)

I've noticed that the magic word {{REVISIONUSER}} renders as a blank string
when placed in an edit notice. This sounds suspiciously like the same bug.

These are not related as far as I know. Please open a new bug for that including steps to reproduce or a live example.

Thanks :)

tagging bugs for Marcus to look at