Page MenuHomePhabricator

Revision information not rendered in edit notices
Closed, DeclinedPublic


Since the update, magic words such as {{REVISIONID}} and {{REVISIONUSER}} result in blank strings when they appear in an edit notice. Presumably these ought to report the values for the last saved revision of the page one is about to edit.


Compared to:

I've included a number of other magic words to show that most of these still render correctly.

Version: 1.18.x
Severity: normal



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:48 PM
bzimport set Reference to bz31398.
bzimport added a subscriber: Unknown Object (MLST).

This use was always considered incorrect and was fixed per bug 19006.

No, the prior behavior was to show the name of the current user loading the page. However, the current behavior is to show nothing. If the point of the revision functions is to show information about the last saved revision, then neither behavior is correct.

I'm not looking for a {{CURRENTUSER}}. I'm just looking for revision magic words that actually report information about the saved revision.

You are right- it should not show nothing.

Note that the behaviour of {{REVISIONID}} and {{REVISIONUSER}} in an edit page
preview IS to return blank. It seams the behaviour has just changed to use the
behaviour of an edit page preview (since you are on the edit page) rather than
the latest revision of the page or some custom behaviour.

This has also broken all the policy and guideline editnotices, which use {{tl|policy-guideline-editnotice}}, which uses {{tlc|REVISIONUSER}}

We very sorry this could included in 1.18, but this we decided to take care of the long-open bug to remove this feature.