Page MenuHomePhabricator

Schema changes: Make ptrp_tags_updated NULLABLE
Closed, ResolvedPublic

Description

  1. ALTERs to run:
  2. Where to run those changes: s1 (enwiki), s3 (testwiki, test2wiki)
  3. When to run those changes: At any time
  4. If the schema change is backwards compatible: compatible with the current code deployed.
  5. If the schema change has been tested already on some of the test/beta wikis: No
  6. If the data should be made available on the labs replicas and/or dumps: n/a or yes. There are no new columns here, and the column we're changing is not sensitive.

Progress:

  • s1
  • s3 (testwiki)
  • s3 (test2wiki)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
jsn.sherman renamed this task from make pagetriage_tags.ptrp_tags_updated nullable on enwiki to Review schema changes for T333389.Apr 12 2023, 2:30 AM

Change 908195 had a related patch set uploaded (by Marostegui; author: Marostegui):

[operations/software/schema-changes@master] change_ptrp_tags_update_T334536.py: New schema change

https://gerrit.wikimedia.org/r/908195

Marostegui renamed this task from Review schema changes for T333389 to Schema changes: Make ptrp_tags_updated NULLABLE .Apr 12 2023, 7:25 AM

Why is this only for s1?

The extension is only deployed in a handful of wikis, most notably English Wikipedia:

'wmgEnablePageTriage' => [
        'default' => false,
        'testwiki' => true,
        'test2wiki' => true,
        'enwiki' => true,
],

But it's enabled in testwikis + I think there is a plan to enable it in another very small wiki (newiki?). So s3 is also should be there as well.

So it needs to be:
s1 (enwiki)
s3 (testwiki)
s3 (test2wiki)

Marostegui triaged this task as Medium priority.Apr 12 2023, 7:50 AM
Marostegui updated the task description. (Show Details)
Marostegui updated the task description. (Show Details)

It "should be"TM quite small in the test wikis, possibly running it with replication

Pretty small indeed on enwiki.
So this is good to go right? I am confused with the discussion at T333389 right @Ladsgroup?

Change 908195 merged by jenkins-bot:

[operations/software/schema-changes@master] change_ptrp_tags_update_T334536.py: New schema change

https://gerrit.wikimedia.org/r/908195

Yes. It's good to go if you ask me. That discussion was mostly about the code in extension.

Mentioned in SAL (#wikimedia-operations) [2023-04-12T08:03:31Z] <marostegui> dbmaint Deploy schema change on s3 codfw with replication enabled (only for testwiki and test2wiki) T334536

Mentioned in SAL (#wikimedia-operations) [2023-04-12T08:37:26Z] <marostegui> dbmaint Deploy schema change on s1 codfw with replication T334536

Marostegui updated the task description. (Show Details)

This is all done

Thank you for interpreting my not-quite-right request and for acting so quickly.