Page MenuHomePhabricator
Create Task
Maniphest T334610

Fix CdxButton instances that define type=quiet property and change that to weight=quiet
Closed, ResolvedPublicBUG REPORT
Actions

Description

Description

According to the latest version of Codex buttons, we should use weight=quiet to have border-less buttons. We are using type=quiet in some instances.

CleanShot 2023-04-12 at 18.21.56@2x.png (680×1 px, 73 KB)

CleanShot 2023-04-12 at 18.23.33@2x.png (1×1 px, 126 KB)

Expected behavior (Acceptance criteria):

  • All CdxButton instances that have type=quiet should be fixed to weight=quiet

Completion checklist

Details

SubjectRepoBranchLines +/-
Fix two CdxButton instances still using type=quiet to use weight=quietmediawiki/extensions/WikiLambdamaster+2 -2
Customize query in gerrit

Event Timeline

gengh created this task.Apr 12 2023, 4:34 PM
• JKieserman subscribed.Apr 14 2023, 12:51 PM

It looks like Anne already did this? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/900415

Jdforrester-WMF subscribed.Apr 17 2023, 1:05 PM
In T334610#8781653, @JKieserman wrote:

It looks like Anne already did this? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/900415

Maybe we added/refactored a couple that got missed?

resources/ext.wikilambda.edit/components/function/viewer/details/FunctionViewerDetailsSidebar.vue
124:						type: 'quiet',

resources/ext.wikilambda.edit/components/function/ZFunctionTesterReport.vue
17:				<cdx-button :aria-label="reloadLabel" type="quiet">
gerritbot added a comment.Apr 17 2023, 1:10 PM

Change 909252 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Fix two CdxButton instances still using type=quiet to use weight=quiet

https://gerrit.wikimedia.org/r/909252

gerritbot added a project: Patch-For-Review.Apr 17 2023, 1:10 PM
gerritbot added a comment.Apr 17 2023, 1:27 PM

Change 909252 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Fix two CdxButton instances still using type=quiet to use weight=quiet

https://gerrit.wikimedia.org/r/909252

Maintenance_bot removed a project: Patch-For-Review.Apr 17 2023, 1:30 PM
Jdforrester-WMF claimed this task.Apr 17 2023, 3:31 PM
Jdforrester-WMF moved this task from To triage to Phase θ – Throttling on the Abstract Wikipedia team board.Apr 17 2023, 3:49 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to QA / Ready to close on the Abstract Wikipedia team (Phase θ – Throttling) board.Apr 17 2023, 3:52 PM
Jdforrester-WMF closed this task as Resolved.May 11 2023, 2:05 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.9; 2023-05-15).May 15 2023, 2:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL