The use of IDatabase::unionConditionPermutations results in use of raw sql via IDatabase::query and needs a replacement.
Maybe the new UnionQueryBuilder (T333690) can take care of this permutation condition.
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | Ladsgroup | T343098 [epic] Data Persistence Hypothesis WE 3.2.1 | |||
| Open | Ladsgroup | T210206 Deprecate raw SQL conditions for IDatabase methods (select, insert, etc.) | |||
| Resolved | Ladsgroup | T334661 rdbms: Find a way to use IDatabase::unionConditionPermutations without raw SQL |
Event Timeline
Comment Actions
It's only used in Special:ShortPages, I honestly think we probably should get rid of it. From a glance it should be possible to refactor it to avoid it but maybe I'm missing something
Comment Actions
I read it and honestly it doesn't justify a dedicated and complex method like this. Specially given the fact that we are moving away from arrays as "query"s
Comment Actions
Change 926570 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):
[mediawiki/core@master] Completely get rid of Database::unionConditionPermutations()
Comment Actions
Change 927258 had a related patch set uploaded (by Krinkle; author: Krinkle):
[mediawiki/core@master] SpecialShortPages: Document reason for "reallyDoQuery" override
Comment Actions
Change 926570 merged by jenkins-bot:
[mediawiki/core@master] rdbms: Remove Database::unionConditionPermutations() and callers
Comment Actions
Change 927258 merged by jenkins-bot:
[mediawiki/core@master] SpecialShortPages: Document reason for "reallyDoQuery" override