Page MenuHomePhabricator

Error messages are described as warnings
Closed, ResolvedPublic

Description

When file name contains characters which are not permitted the upload form shows a warning message while in fact this is a blocking error.


Version: 1.20.x
Severity: normal

Details

Reference
bz31496

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 21 2014, 11:55 PM
bzimport added a project: MediaWiki-Uploading.
bzimport set Reference to bz31496.
bzimport added a subscriber: Unknown Object (MLST).
TomerA created this task.Oct 7 2011, 3:11 PM

Created attachment 9209
Patch

Changed the description from warning to error (string already existed). As far as I can tell, this method (showRecoverableUploadError) is never called by warnings, only by errors (MIN_LENGTH_PARTNAME, ILLEGAL_FILENAME, FILENAME_TOO_LONG, FILETYPE_MISSING, WINDOWS_NONASCII_FILENAME and verifyTitlePermissions).

This is my first patch, please be gentle.

attachment SpecialUpload.php ignored as obsolete

Any chance the patch could be attached in unified diff format ([[w:Diff#Unified_format]]).

Thanks.

Created attachment 9218
Unified diff?

Like that?

attachment patch.txt ignored as obsolete

Created attachment 9219
patch, unified diff

Better yet.

attachment patch.txt ignored as obsolete

(In reply to comment #4)

Created attachment 9219 [details]
patch, unified diff
Better yet.

Yep, that's much better.

attachment patch.txt ignored as obsolete

Created attachment 9227
SVN diff, as Per Amir's request.

Attached:

Patch applied in r99700 (what a nice number).

Thank you.

tagging bugs for Marcus to look at

Gilles moved this task from Untriaged to Done on the Multimedia board.Dec 4 2014, 10:10 AM
Restricted Application added subscribers: Steinsplitter, Matanya. · View Herald TranscriptJan 28 2016, 6:04 PM