Page MenuHomePhabricator
Create Task
Maniphest T335469

Uncaught TypeError: can't access property "items", this.actionsToolbar.getToolGroupByName(...) is null
Closed, ResolvedPublic
Actions

Description

Yesterday I edited https://www.mediawiki.org/w/index.php?title=Manual%253ARunning_MediaWiki_on_macOS. After saving the edit in VE, I clicked on the edit link for section 9 and got this console error:

Uncaught TypeError: can't access property "items", this.actionsToolbar.getToolGroupByName(...) is null
    setupToolbarSaveButton https://www.mediawiki.org/w/index.php?title=Manual:Running_MediaWiki_on_macOS&action=edit&section=7 line 1256 > injectedScript:5
    setupToolbar https://www.mediawiki.org/w/index.php?title=Manual:Running_MediaWiki_on_macOS&action=edit&section=7 line 1256 > injectedScript:427
    setupToolbar https://www.mediawiki.org/w/index.php?title=Manual:Running_MediaWiki_on_macOS&action=edit&section=7 line 1256 > injectedScript:4
    setSurface https://www.mediawiki.org/w/load.php?lang=en&modules=ext.visualEditor.base,core,diffing,mwsave,mwtransclusion&skin=vector-2022&version=1faib:21
    setSurface https://www.mediawiki.org/w/index.php?title=Manual:Running_MediaWiki_on_macOS&action=edit&section=7 line 1256 > injectedScript:1054
    setSurface https://www.mediawiki.org/w/index.php?title=Manual:Running_MediaWiki_on_macOS&action=edit&section=7 line 1256 > injectedScript:9
    addSurface https://www.mediawiki.org/w/index.php?title=Manual:Running_MediaWiki_on_macOS&action=edit&section=7 line 1256 > injectedScript:1054
    addSurface https://www.mediawiki.org/w/index.php?title=Manual:Running_MediaWiki_on_macOS&action=edit&section=7 line 1256 > injectedScript:3
    setupSurface https://www.mediawiki.org/w/index.php?title=Manual:Running_MediaWiki_on_macOS&action=edit&section=7 line 1256 > injectedScript:1053

The error went away after I reloaded the page.

I would expect the message to show up in mw-client-errors dashboard in Logstash, but I did not see it there.

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (abffa3e09)mediawiki/extensions/VisualEditormaster+1 -1
ve.init.Target: Fix actions toolbar teardown compatibilityVisualEditor/VisualEditormaster+3 -0
Replace references to actionsToolbarmediawiki/extensions/VisualEditorwmf/1.41.0-wmf.6+14 -19
Replace references to actionsToolbarmediawiki/extensions/VisualEditormaster+14 -19
Customize query in gerrit

Related Objects
Search...

Event Timeline

kostajh created this task.Apr 27 2023, 7:33 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 27 2023, 7:33 AM
matmarex subscribed.Apr 27 2023, 1:20 PM

Found in Logstash: https://logstash.wikimedia.org/goto/a1e0563859595b38161ca29fcfebaf60

image.png (543×2 px, 55 KB)

May be related to https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/908638

matmarex added a parent task: T330212: 1.41.0-wmf.6 deployment blockers.Apr 27 2023, 1:20 PM
matmarex added a comment.Apr 27 2023, 1:31 PM

I can reproduce by simply launching, closing, and launching the editor again.

matmarex claimed this task.Apr 27 2023, 1:34 PM
matmarex added a project: Editing-team (Kanban Board).
matmarex moved this task from To Triage to Triaged on the VisualEditor board.
gerritbot added a comment.Apr 27 2023, 1:44 PM

Change 912860 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[VisualEditor/VisualEditor@master] ve.init.Target: Fix actions toolbar teardown compatibility

https://gerrit.wikimedia.org/r/912860

gerritbot added a project: Patch-For-Review.Apr 27 2023, 1:44 PM
gerritbot added a comment.Apr 27 2023, 1:52 PM

Change 912861 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Replace references to actionsToolbar

https://gerrit.wikimedia.org/r/912861

matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.Apr 27 2023, 1:53 PM

Either of these patches will fix the problem. The second one (in mediawiki/extensions/VisualEditor) will be easier to backport.

gerritbot added a comment.Apr 27 2023, 2:37 PM

Change 912861 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Replace references to actionsToolbar

https://gerrit.wikimedia.org/r/912861

gerritbot added a comment.Apr 27 2023, 2:40 PM

Change 911804 had a related patch set uploaded (by Jforrester; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@wmf/1.41.0-wmf.6] Replace references to actionsToolbar

https://gerrit.wikimedia.org/r/911804

Agusbou2015 subscribed.Apr 27 2023, 3:19 PM
gerritbot added a comment.Apr 27 2023, 6:20 PM

Change 911804 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.41.0-wmf.6] Replace references to actionsToolbar

https://gerrit.wikimedia.org/r/911804

Stashbot added a comment.Apr 27 2023, 6:21 PM

Mentioned in SAL (#wikimedia-operations) [2023-04-27T18:21:00Z] <jhuneidi@deploy1002> Started scap: Backport for [[gerrit:911804|Replace references to actionsToolbar (T335469)]]

Stashbot added a comment.Apr 27 2023, 6:22 PM

Mentioned in SAL (#wikimedia-operations) [2023-04-27T18:22:49Z] <jhuneidi@deploy1002> jhuneidi and jforrester: Backport for [[gerrit:911804|Replace references to actionsToolbar (T335469)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet

kostajh added a comment.Apr 27 2023, 6:27 PM
In T335469#8810553, @matmarex wrote:

Found in Logstash: https://logstash.wikimedia.org/goto/a1e0563859595b38161ca29fcfebaf60

image.png (543×2 px, 55 KB)

May be related to https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/908638

Oops. I had lazily searched for "getToolGroupByName" which returns nothing, while your query for "this.actionsToolbar.getToolGroupByName" finds the entries.

Umherirrender added projects: Wikimedia-production-error, JavaScript.Apr 27 2023, 6:36 PM
Stashbot added a comment.Apr 27 2023, 6:37 PM

Mentioned in SAL (#wikimedia-operations) [2023-04-27T18:37:11Z] <jhuneidi@deploy1002> Finished scap: Backport for [[gerrit:911804|Replace references to actionsToolbar (T335469)]] (duration: 16m 10s)

gerritbot added a comment.May 4 2023, 3:12 PM

Change 912860 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] ve.init.Target: Fix actions toolbar teardown compatibility

https://gerrit.wikimedia.org/r/912860

Maintenance_bot removed a project: Patch-For-Review.May 4 2023, 3:29 PM
gerritbot added a comment.May 4 2023, 4:02 PM

Change 915738 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (abffa3e09)

https://gerrit.wikimedia.org/r/915738

gerritbot added a project: Patch-For-Review.May 4 2023, 4:02 PM
gerritbot added a comment.May 4 2023, 4:32 PM

Change 915738 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (abffa3e09)

https://gerrit.wikimedia.org/r/915738

Maintenance_bot removed a project: Patch-For-Review.May 4 2023, 5:10 PM
matmarex closed this task as Resolved.May 4 2023, 5:49 PM
matmarex moved this task from Code Review to Ready for Sign Off on the Editing-team (Kanban Board) board.
matmarex added a project: Skipped QA.

Error logs cleaned up as expected:

image.png (525×2 px, 57 KB)

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.9; 2023-05-15).May 16 2023, 12:02 AM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.10; 2023-05-23); removed MW-1.41-notes (1.41.0-wmf.9; 2023-05-15).May 16 2023, 10:01 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL