Page MenuHomePhabricator
Create Task
Maniphest T336107

Mobile preferences: Click on toggle labels can change their value but not the visual state of widgets
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:

Save button becomes enabled, you can save the value, but the toggle state didn't change.

Screenshot 2023-05-07 012506.png (498×867 px, 35 KB)

What should have happened instead?:

Clicking on the label should change the toggle state visually.

Screenshot 2023-05-07 012528.png (490×870 px, 35 KB)

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

SubjectRepoBranchLines +/-
Implement HTMLToggleSwitchField for mobile layout of preferencesmediawiki/coremaster+193 -33
Customize query in gerrit

Related Objects
Search...

Event Timeline

Func created this task.May 6 2023, 5:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 6 2023, 5:26 PM
Func updated the task description. (Show Details)May 6 2023, 5:27 PM
Func added a project: Moderator-Tools-Team.May 9 2023, 4:34 PM
Func moved this task from Inbox to Preferences on the Moderator-Tools-Team board.
• Samwalton9-WMF updated the task description. (Show Details)May 10 2023, 11:45 AM
Esanders added a parent task: T336879: Issues with toggles on mobile.May 17 2023, 3:34 PM
gerritbot added a comment.May 17 2023, 4:27 PM

Change 920339 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] Implement HTMLToggleSwitchField for mobile layout of preferences

https://gerrit.wikimedia.org/r/920339

gerritbot added a project: Patch-For-Review.May 17 2023, 4:27 PM
PatchDemoBot added a comment.May 17 2023, 5:45 PM

Test wiki created on Patch demo by JSherman (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/34de885f3a/wiki/Special:Preferences

gerritbot added a comment.May 17 2023, 6:51 PM

Change 920339 merged by jenkins-bot:

[mediawiki/core@master] Implement HTMLToggleSwitchField for mobile layout of preferences

https://gerrit.wikimedia.org/r/920339

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).May 17 2023, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 17 2023, 7:10 PM
Func mentioned this in T336933: Unknown widget type: id: mw-input-wpbetafeatures-auto-enroll, class: mw.widgets.ToggleSwitchWidget.May 18 2023, 12:24 PM
jsn.sherman closed this task as Resolved.Jun 2 2023, 4:23 PM
jsn.sherman claimed this task.
PatchDemoBot added a comment.Jun 30 2023, 2:12 PM

Test wiki on Patch demo by JSherman (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/34de885f3a/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL