docs: VitePress demo shows wrong token sizes due to fixed px value
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Volker_E
	May 8 2023, 9:08 PM

Description

Background

VitePress and it's Accessibility breaker again. Since the update (?) the size tokens don't show the real value, as .vp-doc td is set to 14px straight.
It's basically a legacy presentation in the normal theme.

Goal

Overwrite the pixel value to have for example size-100 token show a 16x16 square by default.

Acceptance criteria for done

Change the selector in our own styles in order to make the presentation correct and scalable

Details

	Subject	Repo	Branch	Lines +/-
	Update Codex from v0.9.1 to v0.10.0	mediawiki/core	master	+710 -673
	docs: Use relative sizes for th/td and fix token demo presentation	design/codex	main	+11 -0

Customize query in gerrit

Related Objects

Mentioned In: T326706: ToggleSwitch: Clarify and update desktop versus mobile design

Event Timeline

Volker_E created this task.May 8 2023, 9:08 PM

Restricted Application triaged this task as High priority. · View Herald TranscriptMay 8 2023, 9:08 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 917408 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] docs: Use relative sizes for th/td and fix token demo presentation

https://gerrit.wikimedia.org/r/917408

gerritbot added a project: Patch-For-Review.May 8 2023, 9:56 PM

Volker_E set the point value for this task to 1.May 8 2023, 9:57 PM

Volker_E moved this task from Committed to Code Review on the Design-System-Team (Design-System-Sprint) board.

Change 917408 merged by jenkins-bot:

[design/codex@main] docs: Use relative sizes for th/td and fix token demo presentation

https://gerrit.wikimedia.org/r/917408

Maintenance_bot removed a project: Patch-For-Review.May 8 2023, 11:10 PM

Volker_E reassigned this task from Volker_E to bmartinezcalvo.May 9 2023, 12:51 PM

Volker_E moved this task from Code Review to Design Sign-Off on the Design-System-Team (Design-System-Sprint) board.

Volker_E mentioned this in T326706: ToggleSwitch: Clarify and update desktop versus mobile design.May 9 2023, 2:52 PM

bmartinezcalvo updated the task description. (Show Details)May 10 2023, 8:09 AM

It LGTM!

Change 918598 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[mediawiki/core@master] Update Codex from v0.9.1 to v0.10.0

https://gerrit.wikimedia.org/r/918598

gerritbot added a project: Patch-For-Review.May 10 2023, 8:44 PM

Test wiki created on Patch demo by ATomasevich (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/8333e57f25/w

Test wiki on Patch demo by ATomasevich (WMF) using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/8333e57f25/w/~~

Change 918598 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v0.9.1 to v0.10.0

https://gerrit.wikimedia.org/r/918598

Maintenance_bot removed a project: Patch-For-Review.May 11 2023, 5:12 PM

Volker_E closed this task as Resolved.May 15 2023, 6:26 PM

Volker_E claimed this task.

Volker_E updated the task description. (Show Details)

docs: VitePress demo shows wrong token sizes due to fixed px valueClosed, ResolvedPublic1 Estimated Story PointsActions