Page MenuHomePhabricator

Add component tokens for link colors in Codex
Open, Needs TriagePublic

Description

Background

  • Description: Various link types, currently default links, need specific component tokens separate from the

We have this special treatment of red links as separate component tokens. We should add normal link tokens as well (and probably later dark link tokens). For context, all mw.skin.variables per skin do this already.
Why links specifically? It's fine to refer to the link component with color-progressive et al. But in theming it might make sense to have a link differently approached than all other progressive elements like buttons. Links and buttons should be separated and it's easier (and consistent with red links) to have this separation in links, not in other elements.

  • Known use case(s): mediawiki.skin.variables and skins using it. We've got also an issue where this separation already is useful with T336065.

User stories

  • As skin author, I'd like to separate out link colors from other progressive elements in order to not run into collision with the two similar, but distinctly used styles.

Previous implementations

Design spec

Component spec sheet tbd

Open questions

  • Nomenclature:
    • link or link-default?
    • link-red or link-new?
    • link-dark or link-subtle?

Acceptance criteria for done

Design

  • Design the Figma spec sheet and add it in this task
  • Add the token as Figma style in the library.

Code

  • Implement the tokens in Codex
  • Update components that use these tokens

Event Timeline

bmartinezcalvo renamed this task from Add link color tokens in Codex to Add component tokens for link colors in Codex.May 10 2023, 8:43 AM
bmartinezcalvo updated the task description. (Show Details)
bmartinezcalvo updated the task description. (Show Details)