The color of the legacy Vector TOC toggle became lighter
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Tacsipacsi
	May 5 2023, 3:52 PM

Description

Steps to reproduce

Open a page containing a table of contents using the legacy Vector skin. E.g. https://hu.wikipedia.org/w/index.php?title=Szerkeszt%C5%91vita:Tacsipacsi/Arch%C3%ADv14&useskin=vector&safemode=1.
Look at the toggle button of the table of contents

Actual result

It has a lighter blue color. I’m not 100% sure, but I think it’s the same as the default link color on Vector 2022.

Expected result

It has a darker blue color: the same color as all other links on the page.

Screenshot

The section link has the expected color, the [elrejtés] link is lighter than expected.

Details

	Subject	Repo	Branch	Lines +/-
	mediawiki.skinning: Make toggle label use link color token	mediawiki/core	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T336344: Add component tokens for link colors in Codex
Mentioned Here: T213778: Update link colors in Vector 2022 for improved UX (and consistency)

Event Timeline

Tacsipacsi created this task.May 5 2023, 3:52 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 5 2023, 3:52 PM

@Tacsipacsi this looks like an intentional change coming from mediawiki core in this patch mediawiki.skinning: Use Codex DS tokens for colors & border-colors as such I'm not sure if it should be considered a bug.

We could potentially add an override for this color in legacy Vector though, since it does seem a bit out of place.

Jdrewniak added a project: Web-Team-Backlog.May 5 2023, 4:28 PM

Jdrewniak moved this task from Needs triage to Bugs on the Vector (legacy skin) board.

Thanks for the link! I was sure it was an intentional change in Vector 2022. However, when the link colors were changed in Vector 2022 in T213778, legacy Vector was explicitly out of scope. I’ve commented there a possible solution.

Jdlrobson edited projects, added Design-System-Team; removed Web-Team-Backlog.May 9 2023, 5:02 PM

Change 918351 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] mediawiki.skinning: Make toggle label use link color token

https://gerrit.wikimedia.org/r/918351

gerritbot added a project: Patch-For-Review.May 10 2023, 7:15 AM

Change 918351 merged by jenkins-bot:

[mediawiki/core@master] mediawiki.skinning: Make toggle label use link color token

https://gerrit.wikimedia.org/r/918351

Maintenance_bot removed a project: Patch-For-Review.May 10 2023, 2:10 PM

Volker_E closed this task as Resolved.May 10 2023, 3:55 PM

Volker_E claimed this task.

Volker_E mentioned this in T336344: Add component tokens for link colors in Codex.

matmarex subscribed.May 10 2023, 4:25 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).May 16 2023, 6:01 PM

	F36976920: Screenshot 2023-05-05 at 17-49-21 Szerkesztővita Tacsipacsi_Archív14 – Wikipédia.png
	May 5 2023, 3:52 PM

The color of the legacy Vector TOC toggle became lighterClosed, ResolvedPublicBUG REPORTActions