Maniphest T337150

Make PHPUnit dataProvider static in Wikidata.org tests
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Umherirrender
	May 20 2023, 8:34 PM

Tags

Referenced Files

None

Subscribers

Description

The @dataProvider annotation should be a static function, check and make data provider in the extension, at least:

WikimediaLoadBalancerQueryServicePoolStatusProviderTest with getStatusProvider and getStatusInvalidJSONProvider
WikimediaPrometheusQueryServiceLagProviderTest with getLagsProvider and getLagsInvalidJSONProvider

static and adjust the usages (More infos at T332865).

Initial work was done in d67f9a7fddea50808dfad7a6f04ff0fd7baa3c35

Details

	Subject	Repo	Branch	Lines +/-
	Make all @dataProviders static	mediawiki/extensions/Wikidata.org	master	+16 -39

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Stalled		None	T255792 Quibble runs core:unit tests twice!
		Open		None	T328919 Upgrade to PHPUnit 10
		Open		None	T225730 Reduce runtime of MW shared gate Jenkins jobs to 5 min
		Open		None	T332865 PHPUnit data providers should be simple static functions that return plain data
		Resolved		thiemowmde	T337150 Make PHPUnit dataProvider static in Wikidata.org tests

Event Timeline

Umherirrender created this task.May 20 2023, 8:34 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2023, 8:34 PM

Umherirrender added a parent task: T332865: PHPUnit data providers should be simple static functions that return plain data.May 20 2023, 8:34 PM

Maintenance_bot added a project: Wikidata.May 20 2023, 8:46 PM

Lucas_Werkmeister_WMDE added a project: [DEPRECATED] wdwb-tech.May 30 2023, 11:27 AM

Umherirrender updated the task description. (Show Details)May 30 2023, 7:35 PM

Umherirrender unsubscribed.Jul 12 2023, 8:42 PM

Change 940333 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Wikidata.org@master] Make all @dataProviders static

https://gerrit.wikimedia.org/r/940333

gerritbot added a project: Patch-For-Review.Jul 21 2023, 10:32 AM

Change 940333 merged by jenkins-bot:

[mediawiki/extensions/Wikidata.org@master] Make all @dataProviders static

https://gerrit.wikimedia.org/r/940333

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Aug 6 2023, 10:00 AM

Maintenance_bot removed a project: Patch-For-Review.Aug 6 2023, 10:13 AM

Umherirrender closed this task as Resolved.Aug 6 2023, 10:14 AM

Umherirrender assigned this task to thiemowmde.