Page MenuHomePhabricator

Accommodate temporary users to check if a name is a temporary user name
Closed, DeclinedPublic

Description

Update code that filters out IP addresses from the array of names. Instead of using mw.util.isIPAddress() to check if a name is an IP address, use a method that checks if a name is a temporary user name.

See code snippet below :

modules/ext.checkUser/checkuser/caMultiLock.js

			if ( obj.name && obj.name === 'users[]' ) {
				// Only registered accounts (not IPs) can be locked
				if ( !mw.util.isIPAddress( obj.value ) ) {
					names.push( obj.value );
				}

Event Timeline

Question: Can temporary accounts be locked? If so, then this code does not need updating.

As far as I'm aware there is no answer to this question yet, as T326937 has not had any progress. As long as temporary accounts have a CentralAuth entry, then they can be locked is my understanding.

Dreamy_Jazz closed this task as Declined.EditedDec 22 2023, 3:43 PM

This code only needs to determine whether the user has a entry in the CentralAuth tables. As temporary accounts have an entry and also can be locked, this can be declined as the code is currently correct.