tokens: Remove deprecated `min-size-base`
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Catrope
	May 31 2023, 4:03 AM

Description

Background

In https://gerrit.wikimedia.org/r/c/design/codex/+/923445 we deprecated the min-size-base token in favor of min-size-interactive-pointer, but we haven't yet removed it, and it's still being used in various places. We should migrate existing uses of it and then remove it (or rather, move it to the deprecated aliases file so that it's still exported for wikimedia-ui-base but no longer for Codex users).

It's more straightforward to get rid of all deprecated WikimediaUI Base variables in Codex (the 'deprecated-aliases-wikimedia-ui-base.json' layer) at once than to pick out 1:1. That's why we're focusing just on the downstream consumer side of things here.

Acceptance

Replace min-size-base with min-size-interactive-pointer across repositories (CodeSearch)

Details

Subject	Repo	Branch	Lines +/-
Update OOUI to v0.48.3	mediawiki/core	master	+1 K -1 K
styles, themes: Replace deprecated `@min-size-*` vars	oojs/ui	master	+33 -27
mediawiki.less: Hard remove deprecated `min-size-base` token	mediawiki/core	master	+0 -1
Update Codex from v0.16.1 to v0.17.0	mediawiki/core	master	+1 K -1 K
tokens: Remove min-size-base, make it a deprecated alias	design/codex	main	+4 -4
styles: Replace deprecated `min-size-base` token	mediawiki/extensions/GrowthExperiments	master	+1 -1
styles: Replace deprecated `min-size-base` token	mediawiki/extensions/Kartographer	master	+2 -2
styles: Replace deprecated `min-size-base` token	mediawiki/extensions/MediaSearch	master	+2 -2

Customize query in gerrit

Related Objects

Mentioned Here: T350447: Remove deprecated WikimediaUI Base tokens technical layer

Event Timeline

Catrope created this task.May 31 2023, 4:03 AM

Restricted Application added a project: Design-System-Team. · View Herald TranscriptMay 31 2023, 4:03 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Volker_E renamed this task from Remove deprecated token min-size-base to tokens: Remove deprecated `min-size-base`.May 31 2023, 4:30 AM

Volker_E updated the task description. (Show Details)

Volker_E subscribed.

ldelench_wmf moved this task from Inbox to Contributor Experience on the Codex board.Jun 2 2023, 6:16 PM

ldelench_wmf moved this task from Inbox to Backlog on the Design-System-Team board.

Volker_E added a project: CSS.Jun 9 2023, 8:14 PM

Change 928947 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/MediaSearch@master] styles: Replace deprecated `min-size-base` token

https://gerrit.wikimedia.org/r/928947

gerritbot added a project: Patch-For-Review.Jun 9 2023, 8:22 PM

Change 928948 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/Kartographer@master] styles: Replace deprecated `min-size-base` token

https://gerrit.wikimedia.org/r/928948

Change 928950 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/GrowthExperiments@master] styles: Replace deprecated `min-size-base` token

https://gerrit.wikimedia.org/r/928950

Change 928947 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@master] styles: Replace deprecated `min-size-base` token

https://gerrit.wikimedia.org/r/928947

Change 928948 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] styles: Replace deprecated `min-size-base` token

https://gerrit.wikimedia.org/r/928948

Change 928950 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] styles: Replace deprecated `min-size-base` token

https://gerrit.wikimedia.org/r/928950

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.13; 2023-06-13).Jun 9 2023, 11:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 9 2023, 11:10 PM

Change 945686 had a related patch set uploaded (by Catrope; author: Catrope):

[design/codex@main] tokens: Remove min-size-base, make it a deprecated alias

https://gerrit.wikimedia.org/r/945686

gerritbot added a project: Patch-For-Review.Aug 4 2023, 12:02 AM

Change 945686 merged by jenkins-bot:

[design/codex@main] tokens: Remove min-size-base, make it a deprecated alias

https://gerrit.wikimedia.org/r/945686

Maintenance_bot removed a project: Patch-For-Review.Aug 5 2023, 6:30 PM

Catrope closed this task as Resolved.Aug 7 2023, 3:34 PM

Catrope claimed this task.

Catrope reassigned this task from Catrope to Volker_E.

Change 946638 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] mediawiki.less: Hard remove deprecated `min-size-base` token

https://gerrit.wikimedia.org/r/946638

gerritbot added a project: Patch-For-Review.Aug 7 2023, 11:47 PM

Quickly reopening for the skin variables piece.

Change 949555 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[mediawiki/core@master] Update Codex from v0.16.1 to v0.17.0

https://gerrit.wikimedia.org/r/949555

Test wiki created on Patch demo by ATomasevich (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/6188b4e5fe/w

Change 949555 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v0.16.1 to v0.17.0

https://gerrit.wikimedia.org/r/949555

Change 946638 merged by jenkins-bot:

[mediawiki/core@master] mediawiki.less: Hard remove deprecated `min-size-base` token

https://gerrit.wikimedia.org/r/946638

Maintenance_bot removed a project: Patch-For-Review.Aug 16 2023, 6:31 PM

Test wiki on Patch demo by ATomasevich (WMF) using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/6188b4e5fe/w/~~

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.25; 2023-09-05); removed MW-1.41-notes (1.41.0-wmf.13; 2023-06-13).Aug 29 2023, 7:02 PM

Jdlrobson removed a project: MediaWiki-Core-Skin-Architecture.Sep 8 2023, 9:53 PM

Change 970878 had a related patch set uploaded (by VolkerE; author: VolkerE):

[oojs/ui@master] styles, themes: Replace deprecated `@min-size-*` vars

https://gerrit.wikimedia.org/r/970878

gerritbot added a project: Patch-For-Review.Nov 1 2023, 11:31 PM

Change 970878 merged by jenkins-bot:

[oojs/ui@master] styles, themes: Replace deprecated `@min-size-*` vars

https://gerrit.wikimedia.org/r/970878

Maintenance_bot removed a project: Patch-For-Review.Nov 2 2023, 3:31 PM

Volker_E removed a project: Codex.Nov 2 2023, 4:55 PM

Volker_E updated the task description. (Show Details)

The final step of removing the token itself is tackled in T350447.

Change 980958 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[mediawiki/core@master] Update OOUI to v0.48.3

https://gerrit.wikimedia.org/r/980958

gerritbot added a project: Patch-For-Review.Dec 6 2023, 11:20 PM

Change 980958 merged by jenkins-bot: