Unable to generate user impact for user in RefreshUserImpactJob.
As far as I can see, none apart from logspam.
This happens on eswiki where one of the users meeting the conditions is suppressed.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Do not refresh impact data for hidden users | mediawiki/extensions/GrowthExperiments | master | +17 -0 |
This happens on eswiki where one of the users meeting the conditions is suppressed.
I missed that. Yeah, the user is globally blocked. So, I guess we could use improved logging here. Should we not generate impact data for blocked users?
I think we definitely shouldn't generate impact data for hidden users (User::isHidden), as those users are unable to log in and for all but few highly-privileged users, MediaWiki behaves as if those users didn't exist at all.
Having impact data for blocked users (while not hidden) can be helpful, because blocked users can: (a) visit their homepage (b) edit, if the block is a partial one.
I think we definitely shouldn't generate impact data for hidden users (User::isHidden),
Agreed. I think that's the work to do for this task, then.
Change 925745 had a related patch set uploaded (by Urbanecm; author: Urbanecm):
[mediawiki/extensions/GrowthExperiments@master] Do not refresh impact data for hidden users
Change 925745 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Do not refresh impact data for hidden users
No errors have been recorded for wmf.12 - the last timestamp Jun 8, 2023 @ 07:45:31.691 (logstash link).