Page MenuHomePhabricator

Drop revision_comment_temp in production
Closed, ResolvedPublic

Description

We stopped writing to this table in production, so far without any explosions. We can slowly start dropping it from prod.

Progress:

  • s1
  • s2
  • s3
  • s4
  • s5
  • s6
  • s7
  • s8

Event Timeline

Ladsgroup triaged this task as Medium priority.Jun 7 2023, 11:30 AM
Ladsgroup moved this task from Triage to Ready on the DBA board.

I just did this:

root@db2109.codfw.wmnet[testwiki]> RENAME TABLE revision_comment_temp TO T338284_revision_comment_temp;

Wait until next week to see if that breaks replication or errors and such and then we can move forward with dropping it everywhere.

It hasn't been modified since June 6 in enwiki:

root@dbstore1003:/srv/sqldata.s1/enwiki# ls -l | grep -i revision_comment
-rw-rw---- 1 mysql mysql         1470 May 19 07:26 revision_comment_temp.frm
-rw-rw---- 1 mysql mysql  38084280320 Jun  6 22:49 revision_comment_temp.ibd

Change 929668 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[operations/software/schema-changes@master] Add 2023/drop_revision_comment_temp_T338284.py

https://gerrit.wikimedia.org/r/929668

Change 929668 merged by jenkins-bot:

[operations/software/schema-changes@master] Add 2023/drop_revision_comment_temp_T338284.py

https://gerrit.wikimedia.org/r/929668

Ladsgroup updated the task description. (Show Details)
Ladsgroup moved this task from Ready to In progress on the DBA board.

s3 is taking a while which is expected.

Ladsgroup updated the task description. (Show Details)

grafik.png (995×1 px, 85 KB)

400GB just in clouddb1021 got cleaned up.