Page MenuHomePhabricator
Create Task
Maniphest T338315

Calling a Function Returns Undefined with Degenerate Implementation
Closed, ResolvedPublicBUG REPORT
Actions

Description

Description

Steps to reproduce (step by step instructions, with links, commands and necessary data to reproduce the error)

  1. define a Z8 as a composition, but set Z14K2 to an empty object {}
  2. call that Z8

Observed behavior

  • result will be undefined

Expected behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

  • result should be some kind of Z5

Completion checklist

Details

SubjectRepoBranchLines +/-
Update function-schemata sub-module to HEAD (5cc2fc7)mediawiki/extensions/WikiLambdamaster+1 -1
Customize query in gerrit
TitleReferenceAuthorSource BranchDest Branch
Update function-schemata sub-module to HEAD (5f40813)repos/abstract-wiki/wikifunctions/function-evaluator!29jforrestersync-function-schematamain
Update function-schemata sub-module to HEAD (5f40813)repos/abstract-wiki/wikifunctions/wikilambda-cli!12jforrestersync-function-schematamain
Update function-schemata sub-module to HEAD (4927eba) (BREAKING - changes some test outputs)repos/abstract-wiki/wikifunctions/function-orchestrator!39apinesync-function-schematamain
Test error that results when a composition is not even a ZObject.repos/abstract-wiki/wikifunctions/function-orchestrator!36apineapine-define-the-undefinedmain
Support degenerate quoted objects in the mixed validator, normalization, and canonicalization.repos/abstract-wiki/wikifunctions/function-schemata!22apineapine-norms-canonsmain
Customize query in GitLab

Related Objects
Search...

Event Timeline

cmassaro created this task.Jun 7 2023, 12:21 PM
cmassaro updated the task description. (Show Details)Jun 7 2023, 2:58 PM
Jdforrester-WMF moved this task from To triage to Phase λ – Launch on the Abstract Wikipedia team board.Jun 26 2023, 4:07 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase λ – Launch); removed Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to Engineering tasks on the Abstract Wikipedia team (Phase λ – Launch) board.Jun 26 2023, 4:16 PM
cmassaro claimed this task.Jun 29 2023, 4:21 PM

I can't reproduce this. My suspicion is that it's related to T315649 and is fixed because of the changes to Z885.

Currently, the result contains a quoted empty object in its error, i.e.

{
  Z1K1: 'Z99',
  Z99K1: {}
}

I think this is correct, though.

cmassaro added a comment.Jun 29 2023, 4:43 PM

Ah, there is still a problem here, but it's separate. I will keep this open because we should add a test for the correct behavior, but this can't be fixed until T340770 is.

Jdforrester-WMF added a parent task: T340775: Launch-blocking bugs.Jun 29 2023, 5:52 PM
CodeReviewBot added a comment.Jun 30 2023, 4:18 PM

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/22

Support degenerate objects in mixed quotes.

CodeReviewBot added a project: Patch-For-Review.Jun 30 2023, 4:18 PM
Jdforrester-WMF moved this task from Engineering tasks to In progress on the Abstract Wikipedia team (Phase λ – Launch) board.Jun 30 2023, 4:19 PM
CodeReviewBot added a comment.Jul 10 2023, 6:57 PM

apine updated https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/39

Draft: Update function-schemata sub-module to HEAD (4927eba) (BREAKING - changes some test outputs)

CodeReviewBot added a comment.Jul 11 2023, 3:55 PM

dmartin merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/39

Update function-schemata sub-module to HEAD (4927eba) (BREAKING - changes some test outputs)

CodeReviewBot added a comment.Jul 11 2023, 5:25 PM

apine updated https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/36

Test error that results when a composition is not even a ZObject.

cmassaro moved this task from In progress to QA needed on the Abstract Wikipedia team (Phase λ – Launch) board.Jul 12 2023, 4:43 PM
CodeReviewBot added a comment.Jul 12 2023, 4:44 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/36

Test error that results when a composition is not even a ZObject.

gerritbot added a comment.Jul 13 2023, 11:32 PM

Change 938017 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (5f40813)

https://gerrit.wikimedia.org/r/938017

gerritbot added a comment.Jul 17 2023, 9:28 PM

Change 938017 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (5cc2fc7)

https://gerrit.wikimedia.org/r/938017

Jdforrester-WMF closed this task as Resolved.Jul 19 2023, 2:51 PM
Jdforrester-WMF moved this task from QA needed to Complete on the Abstract Wikipedia team (Phase λ – Launch) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits