Page MenuHomePhabricator

Add a section image: Leave dialog appears after clicking "not sure"
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Start an add section image task
  • Click on "not sure" button
  • When the "Not sure about this image? Confirm that you'd like to skip this suggestion." OOUI dialog comes up, click "Skip suggestion"

What happens?:
The browser's built-in "Are you sure you want to leave?" dialog comes up.

What should have happened instead?:
The browser should just navigate back to the task feed without asking for a (second) confirmation.

Software version (skip for WMF-hosted wikis like Wikipedia):
Tested locally on master.

Other information (browser name/version, screenshots, etc.):
Doesn't happen for "Add an image" tasks.

Event Timeline

Change 929320 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] addsectionimage: Remove beforeunload event

https://gerrit.wikimedia.org/r/929320

Change 929320 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] addsectionimage: Remove beforeunload event

https://gerrit.wikimedia.org/r/929320

Change 929409 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] structuredtask: Re-implement beforeunload hook

https://gerrit.wikimedia.org/r/929409

Change 929409 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] structuredtask: Re-implement beforeunload hook

https://gerrit.wikimedia.org/r/929409

Etonkovidova subscribed.

Checked in beta - the fix is in place:

Screen Shot 2023-06-21 at 2.32.22 PM.png (1×736 px, 440 KB)