Page MenuHomePhabricator
Create Task
Maniphest T339114

🐐️ Make GetStatement work with statements on properties
Closed, ResolvedPublic
Actions

Description

  • allow property IDs in the validator
  • modify GetStatementTest.php and GetStatementValidatorTest.php to contain tests for properties also.

Details

SubjectRepoBranchLines +/-
REST: Refactor `RequestedSubjectIdValidator`mediawiki/extensions/Wikibasemaster+125 -117
REST: Fix `GetStatement` edge casesmediawiki/extensions/Wikibasemaster+366 -168
REST: Make `GetStatement` subject agnosticmediawiki/extensions/Wikibasemaster+470 -325
Customize query in gerrit

Related Objects
Search...

Event Timeline

Muhammad_Yasser_Jazirahly_WMDE created this task.Jun 14 2023, 11:32 AM
Muhammad_Yasser_Jazirahly_WMDE removed a project: Story.Jun 14 2023, 11:37 AM
Muhammad_Yasser_Jazirahly_WMDE removed subscribers: WMDE-leszek, Silvan_WMDE, • WMDE_Norman and 2 others.
Muhammad_Yasser_Jazirahly_WMDE updated the task description. (Show Details)Jun 20 2023, 3:00 PM
• WMDE_Norman claimed this task.Jun 21 2023, 9:57 AM
• WMDE_Norman moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 31) board.
Muhammad_Yasser_Jazirahly_WMDE updated the task description. (Show Details)Jun 21 2023, 11:10 AM
gerritbot added a comment.Jun 21 2023, 3:23 PM

Change 931953 had a related patch set uploaded (by Norman Schwirz; author: Norman Schwirz):

[mediawiki/extensions/Wikibase@master] REST: Make GetStatement more generic

https://gerrit.wikimedia.org/r/931953

gerritbot added a project: Patch-For-Review.Jun 21 2023, 3:23 PM
Muhammad_Yasser_Jazirahly_WMDE updated the task description. (Show Details)Jun 23 2023, 8:52 AM
• WMDE_Norman moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 31) board.Jun 23 2023, 8:56 AM
Ollie.Shotton_WMDE claimed this task.Jun 27 2023, 5:05 PM
Ollie.Shotton_WMDE moved this task from Peer Review to Doing on the Wikibase Product Platform (v1) (Sprint 31) board.
Ollie.Shotton_WMDE added a subscriber: • WMDE_Norman.
WMDE-leszek edited projects, added Wikibase Product Platform (v1) (Sprint 32); removed Wikibase Product Platform (v1) (Sprint 31).Jun 28 2023, 7:54 AM
WMDE-leszek moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 32) board.
Ollie.Shotton_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 32) board.Jun 29 2023, 3:24 PM
Muhammad_Yasser_Jazirahly_WMDE mentioned this in T339140: 🐐 Implement the "GET Property Statement" long route.Jun 30 2023, 2:15 PM
gerritbot added a comment.Jul 4 2023, 12:28 PM

Change 935411 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] REST: Fix subject agnostic `GetStatement` edge cases

https://gerrit.wikimedia.org/r/935411

gerritbot added a comment.Jul 7 2023, 10:38 AM

Change 931953 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Make `GetStatement` subject agnostic

https://gerrit.wikimedia.org/r/931953

gerritbot added a comment.Jul 10 2023, 3:59 PM

Change 935411 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Fix `GetStatement` edge cases

https://gerrit.wikimedia.org/r/935411

Muhammad_Yasser_Jazirahly_WMDE closed this task as Resolved.Jul 10 2023, 4:00 PM
Muhammad_Yasser_Jazirahly_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 32) board.
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.17; 2023-07-11).Jul 10 2023, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 10 2023, 4:10 PM
gerritbot added a comment.Jul 10 2023, 5:27 PM

Change 936773 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] REST: Refactor `RequestedSubjectIdValidator`

https://gerrit.wikimedia.org/r/936773

gerritbot added a project: Patch-For-Review.Jul 10 2023, 5:27 PM
gerritbot added a comment.Jul 12 2023, 9:49 AM

Change 936773 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Refactor `RequestedSubjectIdValidator`

https://gerrit.wikimedia.org/r/936773

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.18; 2023-07-18); removed MW-1.41-notes (1.41.0-wmf.17; 2023-07-11).Jul 12 2023, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 12 2023, 10:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits