Maniphest T339387

Migrate remaining select queries to newSelectQueryBuilder
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Scardenasmolinar
	Jun 16 2023, 7:24 PM

Tags

Referenced Files

None

Subscribers

Scardenasmolinar

Description

Most of the select queries were migrated in T312480, but several of them still use the old select method.

The queries are the following:

https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/PageTriage/+/refs/heads/master/includes/Api/ApiPageTriageList.php#419 - done in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/991875
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/PageTriage/+/refs/heads/master/includes/Api/ApiPageTriageList.php#430 - done in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/991875
https://github.com/wikimedia/mediawiki-extensions-PageTriage/blob/cf57d112e450afe18475d350f8176af2d977555c/includes/ArticleCompile/ArticleCompile.php#L77 - at some point, processEstimatedCount() was refactored to no longer include an SQL query: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/PageTriage/+/refs/heads/master/includes/ArticleCompile/ArticleCompile.php#77
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/PageTriage/+/refs/heads/master/includes/ArticleCompile/ArticleCompileUserData.php#38 - at some point, all selects in this file were upgraded to newSelectQueryBuilder

Details

	Subject	Repo	Branch	Lines +/-
	Migrate remaining select queries to newSelectQueryBuilder	mediawiki/extensions/PageTriage	master	+16 -16

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T349553 [EPIC] Moderator Tools Maintenance Work
		Resolved		Samwalton9-WMF	T348560 [Epic] Q3 FY 2023-24 Moderator Tools Maintenance Work
		Resolved		MPGuy2824	T348835 Migrate code to use new query builder functions
		Resolved		MPGuy2824	T339387 Migrate remaining select queries to newSelectQueryBuilder

Event Timeline

Scardenasmolinar created this task.Jun 16 2023, 7:24 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 16 2023, 7:25 PM

Scardenasmolinar added a parent task: T338040: [Epic] Q1 FY 2023-24 Moderator Tools Maintenance Work.Jun 16 2023, 7:26 PM

Novem_Linguae moved this task from Backlog to Priority technical debt on the PageTriage board.Jul 7 2023, 3:36 AM

jsn.sherman edited parent tasks, added: T348541: [Epic] Q2 FY 2023-24 Moderator Tools Maintenance Work; removed: T338040: [Epic] Q1 FY 2023-24 Moderator Tools Maintenance Work.Oct 10 2023, 2:25 PM

MPGuy2824 mentioned this in T348835: Migrate code to use new query builder functions.Oct 13 2023, 7:47 AM

MPGuy2824 added a parent task: T348835: Migrate code to use new query builder functions.

Scardenasmolinar edited parent tasks, added: T348560: [Epic] Q3 FY 2023-24 Moderator Tools Maintenance Work; removed: T348541: [Epic] Q2 FY 2023-24 Moderator Tools Maintenance Work.Jan 20 2024, 1:46 AM

Change 991875 had a related patch set uploaded (by MPGuy2824; author: MPGuy2824):

[mediawiki/extensions/PageTriage@master] Migrate remaining select queries to newSelectQueryBuilder

https://gerrit.wikimedia.org/r/991875

gerritbot added a project: Patch-For-Review.Jan 20 2024, 3:19 AM

MPGuy2824 changed the task status from Open to In Progress.Jan 20 2024, 3:47 AM

MPGuy2824 claimed this task.

MPGuy2824 moved this task from Priority technical debt to Code Review on the PageTriage board.

MPGuy2824 added a project: Moderator-Tools-Team.Feb 1 2024, 8:59 AM

MPGuy2824 moved this task from Inbox to PageTriage on the Moderator-Tools-Team board.

MPGuy2824 removed a project: Moderator-Tools-Team.Feb 1 2024, 9:04 AM

Novem_Linguae moved this task from Code Review to Priority technical debt on the PageTriage board.Feb 14 2024, 1:59 AM

Change 991875 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Migrate remaining select queries to newSelectQueryBuilder

https://gerrit.wikimedia.org/r/991875

Maintenance_bot removed a project: Patch-For-Review.Feb 15 2024, 5:31 PM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.19; 2024-02-20).Feb 15 2024, 6:00 PM

Novem_Linguae updated the task description. (Show Details)Feb 16 2024, 8:32 AM

Novem_Linguae updated the task description. (Show Details)Feb 16 2024, 8:36 AM

Novem_Linguae closed this task as Resolved.Feb 16 2024, 8:38 AM

Novem_Linguae updated the task description. (Show Details)