Page MenuHomePhabricator
Create Task
Maniphest T339870

Vector 2022: missing icons in the user menu
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
Pginer-WMF
Authored By
Patafisik_WMF
Jun 19 2023, 4:43 PM
Tags
Referenced Files
F37643996: translation_uploaded_media.webm
Aug 31 2023, 3:40 AM
F37134629: Screenshot 2023-07-10 at 10-35-13 Discussion utilisateur Patafisik (WMF) - Wikipedia.png
Jul 10 2023, 8:36 AM
F37109572: Screenshot 2023-06-19 at 18-33-40 Wikipedia the free encyclopedia.png
Jun 19 2023, 4:43 PM
Subscribers
Aklapper
EChukwukere-WMF
Patafisik_WMF

Description

Steps to replicate the issue:

  • enable Vector 2022
  • enable the ContentTranslation, so the user menu contains the links Translations and Uploaded media (after Contributions).
  • go to a page on en.wiki (for example the Main page)
  • open the User menu
  • look at the icons

What happens?:

  • "Translations" and "Uploaded media" have no icons

What should have happened instead?:

  • All links should have icons in in the user menu

Other information (browser name/version, screenshots, etc.):

Screenshot 2023-06-19 at 18-33-40 Wikipedia the free encyclopedia.png (290×162 px, 6 KB)

Details

SubjectRepoBranchLines +/-
Short term fix: Fix icons in user menumediawiki/extensions/ContentTranslationmaster+3 -3
Customize query in gerrit

Related Objects

Event Timeline

Patafisik_WMF created this task.Jun 19 2023, 4:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 19 2023, 4:43 PM
Pginer-WMF edited projects, added Language-Team (Language-2023-July-September); removed Language-Team (Language-2023-April-June).Jun 30 2023, 12:00 PM
Jdlrobson moved this task from Incoming to Tracking (Waiting on other teams) on the Desktop Improvements (Vector 2022) board.Jul 7 2023, 10:06 PM
Patafisik_WMF added a comment.EditedJul 10 2023, 8:36 AM

FYI

Screenshot 2023-07-10 at 10-35-13 Discussion utilisateur Patafisik (WMF) - Wikipedia.png (343×247 px, 13 KB)

This was reported also on MediaWiki concerning tewiki.

Patafisik_WMF mentioned this in T329893: User menu in Vector 2022 shows links on hover (logged-in users).Jul 15 2023, 3:51 PM
gerritbot added a comment.Jul 17 2023, 9:18 PM

Change 938934 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/ContentTranslation@master] Short term fix: Fix icons in user menu

https://gerrit.wikimedia.org/r/938934

gerritbot added a project: Patch-For-Review.Jul 17 2023, 9:18 PM
gerritbot added a comment.Jul 18 2023, 10:46 AM

Change 938934 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Short term fix: Fix icons in user menu

https://gerrit.wikimedia.org/r/938934

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.19; 2023-07-25).Jul 18 2023, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 18 2023, 11:11 AM
Nikerabbit triaged this task as Low priority.Aug 28 2023, 11:40 AM
Nikerabbit moved this task from Quarter Backlog to Needs QA on the Language-Team (Language-2023-July-September) board.
Nikerabbit moved this task from Needs Triage to Bugs on the ContentTranslation board.
EChukwukere-WMF subscribed.Aug 31 2023, 3:40 AM

Test status: QA PASS

EChukwukere-WMF moved this task from Needs QA to Done on the Language-Team (Language-2023-July-September) board.Aug 31 2023, 3:40 AM
Pginer-WMF closed this task as Resolved.Aug 31 2023, 9:14 AM
Pginer-WMF claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL