Support reading Wiki Replica/ToolsDB credentials from envvars
Closed, ResolvedPublicFeature
Actions

Assigned To

Authored By

	bd808
	Jun 20 2023, 3:56 PM

Description

Follow up T265691: [tbs.maintaindbusers] Update maintain-dbusers to create an envvar with replica.my.cnf to be used by buildpack images by making the python-toolforge library use the envvar values when present rather than loading the replica.my.cnf file from disk.

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved	Feature	LucasWerkmeister	T339940 Support reading Wiki Replica/ToolsDB credentials from envvars
Resolved		dcaro	T265691 [tbs.maintaindbusers] Update maintain-dbusers to create an envvar with replica.my.cnf to be used by buildpack images
Duplicate		None	T291409 [NFS] Update maintain_dbusers so it can run on a VM
Resolved		dcaro	T334578 [toolforge] Create a secrets management offering to avoid storing on NFS
Resolved		dcaro	T337538 [toolforge] Create envvars management offering
Resolved		dcaro	T344155 [toolforge-weld] Allow passing embedded certs in the kubeconfig

Event Timeline

bd808 created this task.Jun 20 2023, 3:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 20 2023, 3:56 PM

Blocked on T265691: [tbs.maintaindbusers] Update maintain-dbusers to create an envvar with replica.my.cnf to be used by buildpack images

bd808 added a subtask: T265691: [tbs.maintaindbusers] Update maintain-dbusers to create an envvar with replica.my.cnf to be used by buildpack images.Jun 20 2023, 3:56 PM

dcaro changed the status of subtask T265691: [tbs.maintaindbusers] Update maintain-dbusers to create an envvar with replica.my.cnf to be used by buildpack images from Open to In Progress.Jul 3 2023, 4:47 PM

dcaro closed subtask T265691: [tbs.maintaindbusers] Update maintain-dbusers to create an envvar with replica.my.cnf to be used by buildpack images as Resolved.Sep 1 2023, 7:28 AM

https://wikitech.wikimedia.org/wiki/Help:Toolforge/Build_Service#Connecting_to_ToolsDB_and_WikiReplicas

bd808 merged a task: T345435: Add support for authenticating to Wiki Replicas and ToolsDB via envvar credentials.Sep 1 2023, 1:46 PM

Curious, what would it take to make this happen?

In T339940#10433225, @Sascha wrote:

Curious, what would it take to make this happen?

The current connection logic is in https://gitlab.wikimedia.org/toolforge-repos/python-toolforge/-/blob/main/src/toolforge/__init__.py?ref_type=heads#L75-82. https://wikitech.wikimedia.org/wiki/Help:Toolforge/Building_container_images#Connecting_to_ToolsDB_and_the_Wiki_Replicas is the current documentation for the envvars replacement.

The library needs a small amount of refactoring to take advantage of the newly split envvar credentials for Wiki Replicas vs ToolsDB. It seems like a reasonable implementation of the connect logic would check for the specific username and password envvars for the desired backend, use them if found, and fallback to the the current ~/replica.my.cnf logic if not.

taavi awarded a token.Jun 5 2025, 12:08 PM

lucaswerkmeister opened https://gitlab.wikimedia.org/toolforge-repos/python-toolforge/-/merge_requests/27

Use toolforge envvars if available

LucasWerkmeister claimed this task.Jun 7 2025, 12:50 PM

LucasWerkmeister moved this task from Ready to Doing on the Tool-python-toolforge board.

bd808 merged https://gitlab.wikimedia.org/toolforge-repos/python-toolforge/-/merge_requests/27

Use toolforge envvars if available

lucaswerkmeister opened https://gitlab.wikimedia.org/toolforge-repos/python-toolforge/-/merge_requests/28

Release 6.1.0

lucaswerkmeister merged https://gitlab.wikimedia.org/toolforge-repos/python-toolforge/-/merge_requests/28

Release 6.1.0

Maintenance_bot removed a project: Patch-For-Review.Jun 11 2025, 9:30 AM