Page MenuHomePhabricator
Create Task
Maniphest T340081

TypeError: n.closest is not a function
Closed, DeclinedPublic2 Estimated Story Points
Actions

Description

The following production error is occurring at a rate of 1,625 errors in the last 7 days.

According to TypeScript, event.target can be null so this likely needs a null check in handleDOMEventIfEligible inside src/index.js

https://logstash.wikimedia.org/goto/e510b1091cd4fb0841f978ab70d2c861

Summary of events

  • We attempted to fix the bug (best guess)
  • It wasn't fixed so we added some logging to understand the bug
  • Additional logging showed us that all errors were in the form "T340081: Unexpected DOM element undefined with nodeType undefined" telling us that the DOM element didn't have an nodeType or tagName
  • Since all DOM elements should have nodeType this suggests the client was non-standard. Since all errors came from Amazon.com we could conclude that this bug didn't impact real users and Jon declined the ticket.

Details

SubjectRepoBranchLines +/-
TypeError: n.closest is not a functionmediawiki/extensions/Popupsmaster+12 -9
Don't log for documentElement (nodeType 9)mediawiki/extensions/Popupsmaster+8 -7
Don't log for documentElement (nodeType 9)mediawiki/extensions/Popupswmf/1.41.0-wmf.18+8 -7
Don't log for documentElement (nodeType 9)mediawiki/extensions/Popupswmf/1.41.0-wmf.17+8 -7
Add additional debugging closest bugmediawiki/extensions/Popupswmf/1.41.0-wmf.18+26 -13
Add additional debugging closest bugmediawiki/extensions/Popupswmf/1.41.0-wmf.17+26 -13
Add additional debugging closest bugmediawiki/extensions/Popupsmaster+26 -13
TypeError: n.closest is not a functionmediawiki/extensions/Popupsmaster+36 -7
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Jun 21 2023, 10:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 21 2023, 10:58 PM
Jdlrobson triaged this task as High priority.Jun 21 2023, 10:58 PM

Volume is high enough for this to be considered high.

Jdlrobson updated the task description. (Show Details)Jun 21 2023, 10:59 PM
Edtadros set the point value for this task to 2.Jun 22 2023, 5:30 PM
Jdlrobson moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 1) board.Jun 29 2023, 5:45 PM
gerritbot added a comment.Jul 4 2023, 2:21 PM

Change 935135 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/extensions/Popups@master] TypeError: n.closest is not a function

https://gerrit.wikimedia.org/r/935135

gerritbot added a project: Patch-For-Review.Jul 4 2023, 2:21 PM
• Mabualruz claimed this task.Jul 4 2023, 2:21 PM
• Mabualruz moved this task from Ready for Development to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 1) board.
Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 1) board.Jul 5 2023, 4:57 PM
• Mabualruz moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 1) board.Jul 7 2023, 11:09 AM
• Mabualruz moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 1) board.Jul 7 2023, 12:34 PM
• Mabualruz moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 1) board.
Jdlrobson claimed this task.Jul 10 2023, 5:33 PM
Jdlrobson added a subscriber: • Mabualruz.
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 1) board.Jul 10 2023, 6:50 PM
gerritbot added a comment.Jul 10 2023, 7:03 PM

Change 935135 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] TypeError: n.closest is not a function

https://gerrit.wikimedia.org/r/935135

Jdlrobson moved this task from QA to Ready for Signoff on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 1) board.Jul 10 2023, 7:04 PM

Can skip QA in production and be verified after deployment.

Maintenance_bot removed a project: Patch-For-Review.Jul 10 2023, 7:11 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.17; 2023-07-11).Jul 10 2023, 8:00 PM
Jdlrobson added a comment.EditedJul 13 2023, 8:25 PM

The error is still occurring, albeit at a much lower rate from a single client. I'll check again tomorrow to see if this could relate to cache.

Jdlrobson moved this task from Ready for Signoff to Needs More Work on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 1) board.Jul 14 2023, 3:57 PM

The error is still occurring at a similar rate.
Since we don't understand this error, this seems like a great application of mw.errorLogger. Perhaps if we can get a change into next release we can seek to fix it next sprint.

var err = new Error( 'T340081' );
err.stack = JSON.stringify( { nodeType, text: node.textContent } );
mw.errorLogger.logError(err, 'webteam')
Jdlrobson reassigned this task from Jdlrobson to • Mabualruz.Jul 14 2023, 3:58 PM
Jdlrobson lowered the priority of this task from High to Low.Jul 14 2023, 4:12 PM

Looking more closely at the logstash errors, a lot of these errors seem to be originating from an Amazon ISP. I'm a bit suspicious that these might be being triggered programmatically so I'm lowering the priority to low and filtering those from the logstash board.

ovasileva edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 3); removed Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 1).Jul 17 2023, 5:22 PM
gerritbot added a comment.Jul 17 2023, 9:55 PM

Change 938944 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Popups@master] Add additional debugging closest bug

https://gerrit.wikimedia.org/r/938944

gerritbot added a project: Patch-For-Review.Jul 17 2023, 9:55 PM
• Mabualruz added a comment.Jul 18 2023, 1:34 PM

the patch LGTM
@Jdlrobson just since mw.errorLogger.logError is nothing I used before I have 1 question: where we can check these logs, does it also show in logstash? or a different place?

gerritbot added a comment.Jul 18 2023, 2:47 PM

Change 938944 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Add additional debugging closest bug

https://gerrit.wikimedia.org/r/938944

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.19; 2023-07-25); removed MW-1.41-notes (1.41.0-wmf.17; 2023-07-11).Jul 18 2023, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 18 2023, 3:10 PM
gerritbot added a comment.Jul 18 2023, 5:08 PM

Change 939329 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Popups@wmf/1.41.0-wmf.17] Add additional debugging closest bug

https://gerrit.wikimedia.org/r/939329

gerritbot added a project: Patch-For-Review.Jul 18 2023, 5:08 PM

Change 939330 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Popups@wmf/1.41.0-wmf.18] Add additional debugging closest bug

https://gerrit.wikimedia.org/r/939330

gerritbot added a comment.Jul 18 2023, 8:06 PM

Change 939329 merged by jenkins-bot:

[mediawiki/extensions/Popups@wmf/1.41.0-wmf.17] Add additional debugging closest bug

https://gerrit.wikimedia.org/r/939329

gerritbot added a comment.Jul 18 2023, 8:17 PM

Change 939330 merged by jenkins-bot:

[mediawiki/extensions/Popups@wmf/1.41.0-wmf.18] Add additional debugging closest bug

https://gerrit.wikimedia.org/r/939330

Stashbot mentioned this in T341812: Mobile login watermark large and uncentered.Jul 18 2023, 8:17 PM

Mentioned in SAL (#wikimedia-operations) [2023-07-18T20:17:54Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:939329|Add additional debugging closest bug (T340081)]], [[gerrit:939330|Add additional debugging closest bug (T340081)]], [[gerrit:939331|Fixes: Mobile login watermark large and uncentered (T341812)]]

Stashbot added a comment.Jul 18 2023, 8:19 PM

Mentioned in SAL (#wikimedia-operations) [2023-07-18T20:19:28Z] <urbanecm@deploy1002> urbanecm and jdlrobson: Backport for [[gerrit:939329|Add additional debugging closest bug (T340081)]], [[gerrit:939330|Add additional debugging closest bug (T340081)]], [[gerrit:939331|Fixes: Mobile login watermark large and uncentered (T341812)]] synced to the testservers mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, and mw-debug kubernetes de

Stashbot added a comment.Jul 18 2023, 8:28 PM

Mentioned in SAL (#wikimedia-operations) [2023-07-18T20:28:22Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:939329|Add additional debugging closest bug (T340081)]], [[gerrit:939330|Add additional debugging closest bug (T340081)]], [[gerrit:939331|Fixes: Mobile login watermark large and uncentered (T341812)]] (duration: 10m 28s)

Maintenance_bot removed a project: Patch-For-Review.Jul 18 2023, 8:31 PM
gerritbot added a comment.Jul 18 2023, 8:34 PM

Change 939364 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Popups@master] Don't log for documentElement (nodeType 9)

https://gerrit.wikimedia.org/r/939364

gerritbot added a project: Patch-For-Review.Jul 18 2023, 8:34 PM
gerritbot added a comment.Jul 18 2023, 8:36 PM

Change 939332 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Popups@wmf/1.41.0-wmf.17] Don't log for documentElement (nodeType 9)

https://gerrit.wikimedia.org/r/939332

gerritbot added a comment.Jul 18 2023, 8:42 PM

Change 939333 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Popups@wmf/1.41.0-wmf.18] Don't log for documentElement (nodeType 9)

https://gerrit.wikimedia.org/r/939333

gerritbot added a comment.Jul 18 2023, 8:47 PM

Change 939332 merged by jenkins-bot:

[mediawiki/extensions/Popups@wmf/1.41.0-wmf.17] Don't log for documentElement (nodeType 9)

https://gerrit.wikimedia.org/r/939332

Stashbot added a comment.Jul 18 2023, 8:52 PM

Mentioned in SAL (#wikimedia-operations) [2023-07-18T20:52:53Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:939332|Don't log for documentElement (nodeType 9) (T340081)]]

Stashbot added a comment.Jul 18 2023, 8:54 PM

Mentioned in SAL (#wikimedia-operations) [2023-07-18T20:54:24Z] <urbanecm@deploy1002> urbanecm and jdlrobson: Backport for [[gerrit:939332|Don't log for documentElement (nodeType 9) (T340081)]] synced to the testservers mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, and mw-debug kubernetes deployment (accessible via k8s-experimental XWD option)

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.18; 2023-07-18); removed MW-1.41-notes (1.41.0-wmf.19; 2023-07-25).Jul 18 2023, 9:00 PM
Stashbot added a comment.Jul 18 2023, 9:02 PM

Mentioned in SAL (#wikimedia-operations) [2023-07-18T21:02:55Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:939332|Don't log for documentElement (nodeType 9) (T340081)]] (duration: 10m 01s)

gerritbot added a comment.Jul 18 2023, 9:13 PM

Change 939333 merged by jenkins-bot:

[mediawiki/extensions/Popups@wmf/1.41.0-wmf.18] Don't log for documentElement (nodeType 9)

https://gerrit.wikimedia.org/r/939333

Stashbot added a comment.Jul 18 2023, 9:14 PM

Mentioned in SAL (#wikimedia-operations) [2023-07-18T21:14:25Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:939333|Don't log for documentElement (nodeType 9) (T340081)]]

Stashbot added a comment.Jul 18 2023, 9:15 PM

Mentioned in SAL (#wikimedia-operations) [2023-07-18T21:15:56Z] <urbanecm@deploy1002> jdlrobson and urbanecm: Backport for [[gerrit:939333|Don't log for documentElement (nodeType 9) (T340081)]] synced to the testservers mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, and mw-debug kubernetes deployment (accessible via k8s-experimental XWD option)

Stashbot added a comment.Jul 18 2023, 9:22 PM

Mentioned in SAL (#wikimedia-operations) [2023-07-18T21:22:08Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:939333|Don't log for documentElement (nodeType 9) (T340081)]] (duration: 07m 42s)

gerritbot added a comment.Jul 18 2023, 9:37 PM

Change 939364 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Don't log for documentElement (nodeType 9)

https://gerrit.wikimedia.org/r/939364

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.19; 2023-07-25); removed MW-1.41-notes (1.41.0-wmf.18; 2023-07-18).Jul 18 2023, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 18 2023, 10:10 PM
Jdlrobson added a comment.Jul 18 2023, 10:22 PM

We have started collecting data to understand this issue better:
https://logstash.wikimedia.org/goto/72d6d18c1fb404a62db3ed8d79bdbf1e (There was a slight hiccup in the logging which I'm filtering from this link)

Since it is no longer being logged to the unknown channel (which we monitor and trigger alerts on) there is no urgency to resolve this right now.

gerritbot added a comment.Jul 19 2023, 3:12 PM

Change 939276 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/extensions/Popups@master] TypeError: n.closest is not a function - Check if target is jquery object and get the element from it - Fail over to currentTarget in the case target fails in all cases - if it still fails we keep logging an error

https://gerrit.wikimedia.org/r/939276

gerritbot added a project: Patch-For-Review.Jul 19 2023, 3:12 PM
Jdlrobson closed this task as Declined.Jul 20 2023, 3:19 PM
Jdlrobson updated the task description. (Show Details)

The errors we'll seeing come from Amazon. I've summarized why we should decline this ticket in the task description so we can refer back to it. We can retain the logging for now for future reference to this issue.

gerritbot added a comment.Jul 20 2023, 10:47 PM

Change 939276 abandoned by Mabualruz:

[mediawiki/extensions/Popups@master] TypeError: n.closest is not a function

Reason:

https://gerrit.wikimedia.org/r/939276

Maintenance_bot removed a project: Patch-For-Review.Jul 20 2023, 11:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits