You seem to have misunderstood my comment - I can reproduce it on the English Wikipedia all the time (as you can see from my unpatrol log, which consists mostly of me manually adding undeleted pages back to the queue). I couldn't reproduce the problem when I installed PageTriage locally to try to investigate why that was happening.

In T340126#8956300, @Pppery wrote:

You seem to have misunderstood my comment - I can reproduce it on the English Wikipedia all the time (as you can see from my unpatrol log, which consists mostly of me manually adding undeleted pages back to the queue). I couldn't reproduce the problem when I installed PageTriage locally to try to investigate why that was happening.

Thanks, clarified.

I have also tried to reproduce the error locally, but am failing to do so. This is what I have tried:

Scenario 1

• Create an article as an anonymous user (article shows on NPF)
• Delete the article as an admin (article disappears from NPF)
• Undelete article as an admin (article shows on NPF)

Scenario 2

• Create an article as a non-admin user (article shows on NPF)
• Delete the article as an admin (article disappears from NPF)
• Undelete article as an admin (article shows on NPF)

Scenario 3

• Create an article as an admin user (article does not show on NPF)
• Delete the article as an admin (article disappears from NPF)
• Undelete article as an admin (article shows on NPF)

Scenario 4

• Create an article as an anonymous user (article shows on NPF)
• Mark for speedy deletion as an admin
• Delete the article as an admin (article disappears from NPF)
• Undelete article as an admin (article shows on NPF)

Scenario 5

• Create an article as a non-admin user (article shows on NPF)
• Mark for speedy deletion as an admin
• Delete the article as an admin (article disappears from NPF)
• Undelete article as an admin (article shows on NPF)

Scenario 6

• Create an article as an anonymous user (article shows on NPF)
• Mark for proposed deletion as an admin
• Delete the article as an admin (article disappears from NPF)
• Undelete article as an admin (article shows on NPF)

Scenario 7

• Create an article as a non-admin user (article shows on NPF)
• Mark for proposed deletion as an admin
• Delete the article as an admin (article disappears from NPF)
• Undelete article as an admin (article shows on NPF)

I will now proceed to create some tests on PageTriage to see if the error shows up in one test.

Change 939380 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/extensions/PageTriage@master] Add tests for hooks

https://gerrit.wikimedia.org/r/939380

I have added some tests to check if the bug would creep up, but I haven't been able to reproduce it there either. I am open to any new test suggestions.

I saw a couple of the articles from pppery's patrol feed. They all seem to be older articles. You might have to artificially increase the age of the articles by say 6 months (in the db), then run the maint script which removes old articles from the page triage table, then undelete.

Change 939380 merged by Scardenasmolinar:

[mediawiki/extensions/PageTriage@master] Add tests for hooks

https://gerrit.wikimedia.org/r/939380

In T340126#9026694, @MPGuy2824 wrote:

I saw a couple of the articles from pppery's patrol feed. They all seem to be older articles. You might have to artificially increase the age of the articles by say 6 months (in the db), then run the maint script which removes old articles from the page triage table, then undelete.

I have followed your advice and artificially increased the age of one of the articles by 3 years (both in pagetriage_page and the revision table) and removed it from pagetriage_page. I could confirm that it no longer showed up on the NewPagesFeed, so I proceeded to delete it and undelete it. Once I undeleted the article, it showed up in the NewPagesFeed in the correct order (since it was "created" 3 years ago, it showed up at the bottom of the feed).

Documenting the examples provided in the parent task, in the hopes it might help us uncover what's going on here:

White Springs Television

• April 2007: Article is created (before the advent of PageTriage).
• March 2022: Article was deleted by an administrator with the Autopatrolled user right.
• September 2022: Article is undeleted by an administrator without the Autopatrolled user right.
• Article does not show up in NewPagesFeed.

Mannan Wani

• 17 July 2018: Article is created.
• 18 July 2018: Article is deleted by an administrator, who has the Autopatrolled user right by default.
• 19 August 2022: Article is undeleted by an administrator without the Autopatrolled user right.
• Article does not show up in NewPagesFeed.

User:Davey2010/Talkpageheader

• 12 May 2013: Page is created.
• 25 May 2013: Page is deleted by an administrator, who has the Autopatrolled user right by default.
• 25 May 2013: Page is recreated by user without the Autopatrolled user right.
• 28 June 2014: Page is deleted by an administrator, who has the Autopatrolled user right by default.
• 4 September 2022: Page is undeleted by an administrator without the Autopatrolled user right.
• Page shows up in NewPagesFeed.

To clarify some of the above - prior to December 2021, all administrators had the Autopatrolled user right by default. This was separated out in that month, and only given to admins who were autopatrolled prior to gaining adminship (admins could later re-assign the right to themselves, but it wasn't simply part of the admin user right).

Thanks for the investigation! From what I see, the pattern here is when someone without the Autopatrolled user right undeletes an article, it doesn't show up in NewPagesFeed. I'll create an Admin with no auto patrol rights in my local environment and test it.

I was able to create an admin user with no autopatrol rights and the results remain the same. The page is still showing in NewPagesFeed.