Page MenuHomePhabricator

Replace getPrimaryConnection and getReplicaConnection with $this->db in PageTriage tests
Closed, ResolvedPublic


In order to facilitate the removal of PageTriageUtil::getPrimaryConnection() and PageTriageUtil::getReplicaConnection(), we should try to remove as many recurrences of the methods as possible. It seems like tests can use $this->db instead of the former methods.

Acceptance Criteria

  • PageTriageUtil::getPrimaryConnection() and PageTriageUtil::getReplicaConnection() are removed from tests an replaced with $this->db.
  • All tests pass.

Event Timeline

Scardenasmolinar changed the task status from Open to In Progress.Jul 11 2023, 1:38 AM
Scardenasmolinar claimed this task.
Scardenasmolinar moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.

Change 937147 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/extensions/PageTriage@master] Replace PageTriageUtil db connections in tests

Change 937147 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Replace PageTriageUtil db connections in tests