Page MenuHomePhabricator
Create Task
Maniphest T341688

Create LogFormatter for cu_private_event log events
Closed, ResolvedPublic
Actions

Description

A class that extends LogFormatter should be created so that log events in the cu_private_event table can be displayed in Special:CheckUser's 'Get edits' results, Special:Investigate's timeline mode and the CheckUser API's 'Get edits' mode.

TODO:

  • Implement a LogFormatter like class to format the action text for cu_private_event rows
  • Create new message keys where appropriate to fit the standard format for log events in en.json and qqq.json
  • Register the "checkuser-private-event" log type to use the newly created LogFormatter
  • Test the newly created LogFormatter

Details

SubjectRepoBranchLines +/-
Add migrated log event subtype for checkuser-private-event logsmediawiki/extensions/CheckUsermaster+20 -0
Implement LogFormatter class for checkuser-private-event logsmediawiki/extensions/CheckUsermaster+244 -6
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedDreamy_JazzT341829 Enable read new for the event table migration
ResolvedDreamy_JazzT342629 Investigate CheckUser currently saving failed login attempted to usernames which fail RIGOR_VALID
ResolvedDreamy_JazzT341688 Create LogFormatter for cu_private_event log events
· · ·

Event Timeline

Dreamy_Jazz created this task.Jul 12 2023, 12:55 PM
Dreamy_Jazz mentioned this in T324907: Create separate tables for log events in CheckUser.
Dreamy_Jazz edited projects, added Anti-Harassment (AHaT Sprint 32 - Baseball Cap); removed Anti-Harassment.
Dreamy_Jazz moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.
gerritbot added a comment.Jul 12 2023, 12:57 PM

Change 937456 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] [WIP] Implement log formatter for checkuser private rows

https://gerrit.wikimedia.org/r/937456

gerritbot added a project: Patch-For-Review.Jul 12 2023, 12:57 PM
Dreamy_Jazz moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.Jul 13 2023, 6:50 PM
Dreamy_Jazz added a parent task: T341829: Enable read new for the event table migration.Jul 13 2023, 8:03 PM
Dreamy_Jazz moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.Jul 21 2023, 3:40 PM
Dreamy_Jazz added a comment.Jul 21 2023, 3:43 PM

I've moved this into the QA/Testing column, but I would suggest that the QA/Testing of this change be done in either T328995: Enable read new support in Special:CheckUser's 'Get edits' mode or T329200: Enable read new support in Special:Investigate's 'Timeline' tab. This is because this LogFormatter is unused and would be used as part of the patches written for both these tasks.

gerritbot added a comment.Jul 21 2023, 4:21 PM

Change 937456 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Implement LogFormatter class for checkuser-private-event logs

https://gerrit.wikimedia.org/r/937456

Maintenance_bot removed a project: Patch-For-Review.Jul 21 2023, 4:30 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.19; 2023-07-25).Jul 21 2023, 5:00 PM
gerritbot added a comment.Jul 21 2023, 6:30 PM

Change 940401 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Add migrated log event subtype for checkuser-private-event logs

https://gerrit.wikimedia.org/r/940401

gerritbot added a project: Patch-For-Review.Jul 21 2023, 6:30 PM
gerritbot added a comment.Jul 22 2023, 11:39 AM

Change 940401 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Add migrated log event subtype for checkuser-private-event logs

https://gerrit.wikimedia.org/r/940401

Maintenance_bot removed a project: Patch-For-Review.Jul 22 2023, 12:11 PM
Dreamy_Jazz added a parent task: T342629: Investigate CheckUser currently saving failed login attempted to usernames which fail RIGOR_VALID.Jul 25 2023, 11:57 AM
GMikesell-WMF subscribed.Jul 25 2023, 4:43 PM

After discussing with @Dreamy_Jazz, we agreed that we can move this to Done since this will be worked on in a future patch, thanks!

GMikesell-WMF moved this task from QA/Testing 🐞 to Done Q1 2023-2024 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.Jul 25 2023, 4:43 PM
Dreamy_Jazz closed this task as Resolved.Oct 24 2023, 2:35 PM
Dreamy_Jazz removed a parent task: T324907: Create separate tables for log events in CheckUser.Wed, Jun 5, 4:45 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL