Page MenuHomePhabricator
Create Task
Maniphest T341829

Enable read new for the event table migration
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Once read new support is implemented for the Special:CheckUser interfaces, the default state of the extension should change to read new.

Support to read new for Special:Investigate and the API will come at a later stage, but due to their low usage on WMF wikis there is not a great priority to complete support for these interfaces as this blocks tasks in the "release 2" column of http-client-hints.

Steps to complete this task
  • Wait until 4th of December 2023 before starting migration
  • Change the default value in extension.json
  • Enable read new on testwiki
  • Enable read new on group0
  • Enable read new on group1
  • Enable read new on group2

Details

SubjectRepoBranchLines +/-
CheckUser: Enable read new for event tables migration everywhereoperations/mediawiki-configmaster+1 -4
CheckUser: Enable read new for event tables migration on group1operations/mediawiki-configmaster+1 -0
Enable read new on group0 wikisoperations/mediawiki-configmaster+1 -0
Enable read new for event tables migration on testwikioperations/mediawiki-configmaster+1 -0
Set wgCheckUserEventTablesMigrationStage to read newmediawiki/extensions/CheckUsermaster+2 -2
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedFeatureDreamy_JazzT311375 Instead of not showing any results on too many results show the results to the truncation point with a pager that allows generation of more results
 OpenFeatureDreamy_JazzT313446 Make non-CUs linking users and IPs when CUs use block forms in CheckUser harder
Restricted Task
Restricted Task
Restricted Task
 ResolvedSecurityZabeT311337 CVE-2022-39193: Edits with the performer suppressed still show the performer in results from the CheckUser extension
 ResolvedSecurityDreamy_JazzT316414 CVE-2022-39193: Special:Investigate can expose supressed information in check results
 ResolvedSecurityDreamy_JazzT318166 CVE-2022-39193: CheckUser API can expose the suppressed performer
 ResolvedSecurityDreamy_JazzT316360 Oversighted action text is shown in Special:CheckUser when the checkuser does not have the right to see it
Restricted Task
 OpenBUG REPORTNoneT326866 Special:Investigate can expose suppressed information for log events
 ResolvedBUG REPORTDreamy_JazzT326867 CheckUser API can expose suppressed information for log events
 ResolvedBUG REPORTDreamy_JazzT326865 Special:CheckUser can expose suppressed information for log events
 ResolvedDreamy_JazzT253796 Make CheckUser record the log_id of logged actions
 OpenNoneT139810 RFC: Overhaul the CheckUser extension
 OpenNoneT132892 CheckUser UI revamp
 OpenNoneT69811 CheckUsers "Get users" design needs improvements
 OpenFeatureDreamy_JazzT24120 Enhance Blocking and tagging from checkuser interface: add dropdowns
 DuplicateNoneT145340 Split CheckUser mass-block interface to separate special page
 OpenFeatureNoneT324709 Allow the HTMLForm Select and other field to have a minimum length set
 ResolvedFeatureDreamy_JazzT316441 Enforce minimum length of the tag on the client side for the checkuser block form
 ResolvedFeatureDreamy_JazzT321427 Allow HTMLForm text based elements to specify a minimum length
 ResolvedFeatureDreamy_JazzT321439 Allow TextInputWidget to specify the "minlength" attribute
 OpenFeatureNoneT316444 The CheckUser block form should explain why users were not blocked or tagged
 OpenFeatureNoneT314700 Restore the bottom paging links on 'Get users'
 ResolvedBUG REPORTDreamy_JazzT314217 Checkuserblock form is broken when paging links are shown on 'Get users'
 DeclinedFeatureNoneT313451 Separate out when the blocks are made for IPs and users in Special:CheckUser 'get users' mode
 OpenFeatureNoneT18306 Allow user to specify block settings from CU form
 ResolvedGlaisherT41213 Block interface after "Get users" check should allow talk page/send email blocking
 OpenFeatureNoneT329493 Replace Special:CheckUser's 'get users' block form with a usage of Special:InvestigateBlock
 ResolvedDreamy_JazzT339914 Remove CheckUserEnableSpecialInvestigate config
 ResolvedFeatureDreamy_JazzT318458 Add dropdown options for the reason in Special:InvestigateBlock (like Special:Block has)
 ResolvedDreamy_JazzT362569 Test SpecialInvestigateBlock
 OpenNoneT27053 Replace user / talk pages feature of "Get users" creates a user/talk page if it doesnt exist
 ResolvedFeatureDreamy_JazzT318459 Make a clearer visual distinction between the UA and IP list in 'get users'
 ResolvedGlaisherT49505 CheckUser results (userlinks) cannot be customized
 Resolved• NiharikaT24119 Enhance Blocking and tagging from checkuser interface: add new page
 ResolvedNoneT14808 Blocking and tagging from checkuser interface
 ResolvedFeatureDreamy_JazzT16699 More versatile searching in CheckUser log
 DeclinedNoneT15789 Restore the global CheckUser log
 ResolvedFeatureDreamy_JazzT309924 Add check links for both the target and performer in Special:CheckUserLog
 ResolvedFeatureDreamy_JazzT309925 Implement User:Amalthea/culoghelper.js into the CheckUser extension
 DuplicateNoneT140345 Userlinks in CheckUser should be customizable
 OpenNoneT21964 Provide a link to the user on account creation
 DuplicateNoneT144099 Make CheckUser unit-testable
 ResolvedDreamy_JazzT309815 Use OOUI in Special:CheckUser
 ResolvedDreamy_JazzT310019 The Special:CheckUser block form should use OOUI
 ResolvedDreamy_JazzT266586 Use OOUI in SpecialCheckUserLog
Restricted Task
 OpenFeatureNoneT26231 Allow CheckUsers to filter checks for account creations only
 ResolvedDreamy_JazzT139809 Bad output of AbuseFilter blocks in CU get edits
 ResolvedBUG REPORTDreamy_JazzT41013 Incomplete i18n for log entries in CheckUser
 ResolvedBUG REPORTDreamy_JazzT268156 Partial blocks from namespaces are displayed odd
 OpenNoneT311354 Make CheckUser results easier to parse by userscripts
 OpenFeatureNoneT311380 Make certain types of edits in 'Get edits' highlightable for ease of parsing the results
 DeclinedFeatureNoneT54849 Checkuser option "get users" should point out when user password is changed
 OpenFeatureNoneT315488 Show failed login attempts in the results list for the user
Restricted Task
 ResolvedDreamy_JazzT145265 Store check user data action text in structured format
 ResolvedkostajhT257893 [EPIC] Support User-Agent Client Hints header in CheckUser
 OpenNoneT341094 Create client hint mapping rows for CheckUser-worthy events
 OpenNoneT248926 Performance review of checkuser database queries [NOT READY]
 ResolvedtstarlingT342613 CompareService::getTotalEditsFromIp queries exceeding TransactionProfiler limits
 OpenNoneT301992 Insert CheckUser row events during certain 2FA actions
 ResolvedTchandersT326393 IP Address Reveal on Log page
 OpenBUG REPORTNoneT28843 CheckUser results do not appear cleanly for AbuseFilter modifications
 OpenFeatureDreamy_JazzT324907 Create separate tables for log events in CheckUser
 ResolvedDreamy_JazzT341829 Enable read new for the event table migration
 ResolvedDreamy_JazzT330158 Enable write new for the event table migration
 ResolvedDreamy_JazzT328874 Create temporary column in cu_changes to assist in migration to the new tables
 ResolvedMarosteguiT329203 Add new column cuc_only_for_read_old to cu_changes for migration purposes to wmf wikis
 ResolvedDreamy_JazzT341586 Allow write old and new for event table migration
 ResolvedPRODUCTION ERRORDreamy_JazzT342902 Wikimedia\Rdbms\DBQueryError: Error 1054: Unknown column 'cuc_only_for_read_old' in 'field list'Function: MediaWiki\CheckUser\Hooks::onAuthManagerLoginAuthenticateAuditQuery: INSERT INTO `cu_changes` (cuc_page_id,cuc_namespac
 ResolvedMarosteguiT343174 Add missing column cuc_only_for_read_old to testcommonswiki
 ResolvedDreamy_JazzT328992 Add read new support to Special:CheckUser for event table migration
 ResolvedDreamy_JazzT328995 Enable read new support in Special:CheckUser's 'Get edits' mode
 ResolvedBUG REPORTDreamy_JazzT347773 Log action text shown when reading new does not respect the deleted status of the log
 ResolvedDreamy_JazzT328997 Enable read new support in Special:CheckUser's 'Get users' mode
 ResolvedDreamy_JazzT328998 Enable read new support in Special:CheckUser's 'Get IP Addresses' mode
 ResolvedDreamy_JazzT328988 Create a SelectQueryBuilder that allows selecting from all three tables
 ResolvedDreamy_JazzT342629 Investigate CheckUser currently saving failed login attempted to usernames which fail RIGOR_VALID
 ResolvedDreamy_JazzT341688 Create LogFormatter for cu_private_event log events
 ResolvedBUG REPORTDreamy_JazzT347400 Read new cannot parse the log_params of global block log entries
 ResolvedBUG REPORTDreamy_JazzT347669 moveLogEntriesFromCuChanges import inconsistencies

Event Timeline

Dreamy_Jazz created this task.Jul 13 2023, 8:01 PM
Dreamy_Jazz added subtasks: T341688: Create LogFormatter for cu_private_event log events, T330158: Enable write new for the event table migration, T328992: Add read new support to Special:CheckUser for event table migration, T329189: Add read new support to Special:Investigate for event table migration, T341827: Add read new support to the CheckUser API.
Dreamy_Jazz updated the task description. (Show Details)Jul 13 2023, 8:04 PM
Dreamy_Jazz added a parent task: T326393: IP Address Reveal on Log page.
Dreamy_Jazz moved this task from Untriaged to CheckUser on the Anti-Harassment board.Jul 22 2023, 5:47 PM
Dreamy_Jazz removed a parent task: T326393: IP Address Reveal on Log page.Aug 7 2023, 11:04 AM
Tchanders closed subtask T330158: Enable write new for the event table migration as Resolved.Aug 14 2023, 10:21 AM
Tchanders closed subtask T342629: Investigate CheckUser currently saving failed login attempted to usernames which fail RIGOR_VALID as Resolved.Aug 14 2023, 11:04 AM
Dreamy_Jazz added a subtask: T347400: Read new cannot parse the log_params of global block log entries.Sep 26 2023, 2:17 PM
kostajh closed subtask T347400: Read new cannot parse the log_params of global block log entries as Resolved.Oct 2 2023, 9:49 AM
Dreamy_Jazz mentioned this in T316360: Oversighted action text is shown in Special:CheckUser when the checkuser does not have the right to see it.Oct 2 2023, 2:28 PM
Dreamy_Jazz updated the task description. (Show Details)Oct 4 2023, 2:39 PM
Dreamy_Jazz removed a subtask: T329189: Add read new support to Special:Investigate for event table migration.
Dreamy_Jazz removed a subtask: T341827: Add read new support to the CheckUser API.
Dreamy_Jazz added a subtask: T345818: Store client hint mapping rows for login events.Oct 22 2023, 1:11 PM
Dreamy_Jazz removed a subtask: T345818: Store client hint mapping rows for login events.
Dreamy_Jazz closed subtask T341688: Create LogFormatter for cu_private_event log events as Resolved.Oct 24 2023, 2:35 PM
Dreamy_Jazz added a subtask: T347669: moveLogEntriesFromCuChanges import inconsistencies.Oct 24 2023, 2:38 PM
• Niharika closed subtask T347669: moveLogEntriesFromCuChanges import inconsistencies as Resolved.Nov 6 2023, 9:55 PM
Dreamy_Jazz updated the task description. (Show Details)Nov 27 2023, 12:24 PM
Dreamy_Jazz added projects: Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)), Trust and Safety Product Team.
Dreamy_Jazz set the point value for this task to 2.
Dreamy_Jazz updated the task description. (Show Details)Dec 4 2023, 11:20 AM
gerritbot added a comment.Dec 4 2023, 11:20 AM

Change 979913 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Set wgCheckUserEventTablesMigrationStage to read new

https://gerrit.wikimedia.org/r/979913

gerritbot added a project: Patch-For-Review.Dec 4 2023, 11:20 AM
gerritbot added a comment.Dec 4 2023, 11:24 AM

Change 979914 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[operations/mediawiki-config@master] Enable read new for event tables migration on testwiki

https://gerrit.wikimedia.org/r/979914

gerritbot added a comment.Dec 4 2023, 12:32 PM

Change 979913 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Set wgCheckUserEventTablesMigrationStage to read new

https://gerrit.wikimedia.org/r/979913

Dreamy_Jazz updated the task description. (Show Details)Dec 4 2023, 12:41 PM
Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)) board.Dec 4 2023, 2:06 PM
gerritbot added a comment.Dec 4 2023, 2:21 PM

Change 979914 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable read new for event tables migration on testwiki

https://gerrit.wikimedia.org/r/979914

Stashbot added a comment.Dec 4 2023, 2:21 PM

Mentioned in SAL (#wikimedia-operations) [2023-12-04T14:21:41Z] <lucaswerkmeister-wmde@deploy2002> Started scap: Backport for [[gerrit:979914|Enable read new for event tables migration on testwiki (T341829)]]

Stashbot added a comment.Dec 4 2023, 2:22 PM

Mentioned in SAL (#wikimedia-operations) [2023-12-04T14:22:58Z] <lucaswerkmeister-wmde@deploy2002> dreamyjazz and lucaswerkmeister-wmde: Backport for [[gerrit:979914|Enable read new for event tables migration on testwiki (T341829)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Maintenance_bot removed a project: Patch-For-Review.Dec 4 2023, 2:30 PM
Stashbot added a comment.Dec 4 2023, 2:32 PM

Mentioned in SAL (#wikimedia-operations) [2023-12-04T14:32:23Z] <lucaswerkmeister-wmde@deploy2002> Finished scap: Backport for [[gerrit:979914|Enable read new for event tables migration on testwiki (T341829)]] (duration: 10m 42s)

Dreamy_Jazz updated the task description. (Show Details)Dec 4 2023, 3:05 PM
gerritbot added a comment.Dec 4 2023, 3:36 PM

Change 979986 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[operations/mediawiki-config@master] Enable read new on group0 wikis

https://gerrit.wikimedia.org/r/979986

gerritbot added a project: Patch-For-Review.Dec 4 2023, 3:36 PM
gerritbot added a comment.Dec 11 2023, 2:03 PM

Change 979986 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable read new on group0 wikis

https://gerrit.wikimedia.org/r/979986

Stashbot added a comment.Dec 11 2023, 2:03 PM

Mentioned in SAL (#wikimedia-operations) [2023-12-11T14:03:48Z] <samtar@deploy2002> Started scap: Backport for [[gerrit:979986|Enable read new on group0 wikis (T341829)]]

Stashbot added a comment.Dec 11 2023, 2:05 PM

Mentioned in SAL (#wikimedia-operations) [2023-12-11T14:05:02Z] <samtar@deploy2002> samtar and dreamyjazz: Backport for [[gerrit:979986|Enable read new on group0 wikis (T341829)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Maintenance_bot removed a project: Patch-For-Review.Dec 11 2023, 2:10 PM
Stashbot added a comment.Dec 11 2023, 2:11 PM

Mentioned in SAL (#wikimedia-operations) [2023-12-11T14:11:46Z] <samtar@deploy2002> Finished scap: Backport for [[gerrit:979986|Enable read new on group0 wikis (T341829)]] (duration: 07m 57s)

Dreamy_Jazz updated the task description. (Show Details)Dec 11 2023, 3:00 PM
gerritbot added a comment.Dec 11 2023, 3:10 PM

Change 982105 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[operations/mediawiki-config@master] CheckUser: Enable read new for event tables migration on group1

https://gerrit.wikimedia.org/r/982105

gerritbot added a project: Patch-For-Review.Dec 11 2023, 3:10 PM
Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Lute (11th Dec. - 22nd Dec. 2023)); removed Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)).Dec 11 2023, 4:45 PM
Dreamy_Jazz moved this task from Priority Backlog to Ready on the Trust and Safety Product Sprint (Sprint Lute (11th Dec. - 22nd Dec. 2023)) board.Dec 11 2023, 4:53 PM
Dreamy_Jazz claimed this task.Dec 11 2023, 4:56 PM
Dreamy_Jazz closed subtask T328992: Add read new support to Special:CheckUser for event table migration as Resolved.Dec 11 2023, 5:21 PM
Dreamy_Jazz moved this task from Ready to In Progress on the Trust and Safety Product Sprint (Sprint Lute (11th Dec. - 22nd Dec. 2023)) board.Dec 12 2023, 11:31 AM
gerritbot added a comment.Dec 13 2023, 2:51 PM

Change 982105 merged by jenkins-bot:

[operations/mediawiki-config@master] CheckUser: Enable read new for event tables migration on group1

https://gerrit.wikimedia.org/r/982105

Stashbot added a comment.Dec 13 2023, 2:51 PM

Mentioned in SAL (#wikimedia-operations) [2023-12-13T14:51:45Z] <lucaswerkmeister-wmde@deploy2002> Started scap: Backport for [[gerrit:982105|CheckUser: Enable read new for event tables migration on group1 (T341829)]]

Stashbot added a comment.Dec 13 2023, 2:53 PM

Mentioned in SAL (#wikimedia-operations) [2023-12-13T14:53:22Z] <lucaswerkmeister-wmde@deploy2002> lucaswerkmeister-wmde and dreamyjazz: Backport for [[gerrit:982105|CheckUser: Enable read new for event tables migration on group1 (T341829)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Dec 13 2023, 3:00 PM

Mentioned in SAL (#wikimedia-operations) [2023-12-13T15:00:15Z] <lucaswerkmeister-wmde@deploy2002> Finished scap: Backport for [[gerrit:982105|CheckUser: Enable read new for event tables migration on group1 (T341829)]] (duration: 08m 29s)

Dreamy_Jazz updated the task description. (Show Details)Dec 13 2023, 3:02 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 13 2023, 3:10 PM
gerritbot added a comment.Dec 14 2023, 12:38 PM

Change 983178 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[operations/mediawiki-config@master] CheckUser: Enable read new for event tables migration everywhere

https://gerrit.wikimedia.org/r/983178

gerritbot added a project: Patch-For-Review.Dec 14 2023, 12:38 PM
gerritbot added a comment.Dec 18 2023, 2:21 PM

Change 983178 merged by jenkins-bot:

[operations/mediawiki-config@master] CheckUser: Enable read new for event tables migration everywhere

https://gerrit.wikimedia.org/r/983178

Stashbot mentioned this in T349919: Apply common settings to publish events from Lift Wing staging to EventGate.Dec 18 2023, 2:24 PM

Mentioned in SAL (#wikimedia-operations) [2023-12-18T14:24:03Z] <urbanecm@deploy2002> Started scap: Backport for [[gerrit:982873|Add a testing stream for page-prediction-change events (T349919)]], [[gerrit:983178|CheckUser: Enable read new for event tables migration everywhere (T341829)]]

Maintenance_bot removed a project: Patch-For-Review.Dec 18 2023, 2:30 PM
Stashbot added a comment.Dec 18 2023, 2:34 PM

Mentioned in SAL (#wikimedia-operations) [2023-12-18T14:34:15Z] <urbanecm@deploy2002> dreamyjazz and aikochou and urbanecm: Backport for [[gerrit:982873|Add a testing stream for page-prediction-change events (T349919)]], [[gerrit:983178|CheckUser: Enable read new for event tables migration everywhere (T341829)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Dec 18 2023, 2:43 PM

Mentioned in SAL (#wikimedia-operations) [2023-12-18T14:43:03Z] <urbanecm@deploy2002> Finished scap: Backport for [[gerrit:982873|Add a testing stream for page-prediction-change events (T349919)]], [[gerrit:983178|CheckUser: Enable read new for event tables migration everywhere (T341829)]] (duration: 19m 00s)

Dreamy_Jazz closed this task as Resolved.Dec 18 2023, 2:46 PM
Dreamy_Jazz updated the task description. (Show Details)
Dreamy_Jazz moved this task from In Progress to Done on the Trust and Safety Product Sprint (Sprint Lute (11th Dec. - 22nd Dec. 2023)) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL