Enable read new support in Special:CheckUser's 'Get users' mode
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Dreamy_Jazz
	Feb 7 2023, 12:56 AM

Description

Now that CheckUser writes to the new tables for event table migration (T330158), reading from these tables when the migration stage is set to read new can commence.

This task is to add support to read new in Special:CheckUser's 'Get users' mode.

Acceptance criteria

Alias the current query info fields in CheckUserGetUsersPager to prepare for migration
Add code to read from the two new tables when reading new in CheckUserGetUsersPager

Details

	Subject	Repo	Branch	Lines +/-
	Implement read new support for CheckUserGetUsersPager	mediawiki/extensions/CheckUser	master	+222 -40
	Prepare CheckUserGetUsersPager for event table migration	mediawiki/extensions/CheckUser	master	+10 -8

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
			Restricted Task
			Restricted Task
			Restricted Task
Resolved	Security	Zabe	T311337 CVE-2022-39193: Edits with the performer suppressed still show the performer in results from the CheckUser extension
Resolved	Security	Dreamy_Jazz	T316414 CVE-2022-39193: Special:Investigate can expose supressed information in check results
Resolved	Security	Dreamy_Jazz	T318166 CVE-2022-39193: CheckUser API can expose the suppressed performer
Resolved	Security	Dreamy_Jazz	T316360 Oversighted action text is shown in Special:CheckUser when the checkuser does not have the right to see it
			Restricted Task
Open	BUG REPORT	None	T326866 Special:Investigate can expose suppressed information for log events
Open	BUG REPORT	None	T326867 CheckUser API can expose suppressed information for log events
Open	BUG REPORT	None	T326865 Special:CheckUser can expose suppressed information for log events
Open		Dreamy_Jazz	T253796 Make CheckUser record the log_id of logged actions
Open		None	T139810 RFC: Overhaul the CheckUser extension
Open		None	T132892 CheckUser UI revamp
Open		None	T69811 CheckUsers "Get users" design needs improvements
Open	Feature	Dreamy_Jazz	T24120 Enhance Blocking and tagging from checkuser interface: add dropdowns
Duplicate		None	T145340 Split CheckUser mass-block interface to separate special page
Open	Feature	None	T318458 Add dropdown options for the reason in Special:InvestigateBlock (like Special:Block has)
Open	Feature	None	T319517 Allow the OOUI selectandother field to have the required status indicate that either the dropdown or the input box could be used
Open	Feature	None	T324709 Allow the HTMLForm Select and other field to have a minimum length set
Resolved	Feature	Dreamy_Jazz	T316441 Enforce minimum length of the tag on the client side for the checkuser block form
Resolved	Feature	Dreamy_Jazz	T321427 Allow HTMLForm text based elements to specify a minimum length
Resolved	Feature	Dreamy_Jazz	T321439 Allow TextInputWidget to specify the "minlength" attribute
Open	Feature	None	T316444 The CheckUser block form should explain why users were not blocked or tagged
Open	Feature	None	T314700 Restore the bottom paging links on 'Get users'
Resolved	BUG REPORT	Dreamy_Jazz	T314217 Checkuserblock form is broken when paging links are shown on 'Get users'
Open	Feature	None	T313451 Separate out when the blocks are made for IPs and users in Special:CheckUser 'get users' mode
Open	Feature	None	T18306 Allow user to specify block settings from CU form
Resolved		Glaisher	T41213 Block interface after "Get users" check should allow talk page/send email blocking
Open		None	T27053 Replace user / talk pages feature of "Get users" creates a user/talk page if it doesnt exist
Open	Feature	None	T318459 Make a clearer visual distinction between the UA and IP list in 'get users'
Resolved		Glaisher	T49505 CheckUser results (userlinks) cannot be customized
Resolved		Niharika	T24119 Enhance Blocking and tagging from checkuser interface: add new page
Resolved		None	T14808 Blocking and tagging from checkuser interface
Resolved	Feature	Dreamy_Jazz	T16699 More versatile searching in CheckUser log
Declined		None	T15789 Restore the global CheckUser log
Resolved	Feature	Dreamy_Jazz	T309924 Add check links for both the target and performer in Special:CheckUserLog
Resolved	Feature	Dreamy_Jazz	T309925 Implement User:Amalthea/culoghelper.js into the CheckUser extension
Duplicate		None	T140345 Userlinks in CheckUser should be customizable
Open		None	T21964 Provide a link to the user on account creation
Duplicate		None	T144099 Make CheckUser unit-testable
Resolved		Dreamy_Jazz	T309815 Use OOUI in Special:CheckUser
Resolved		Dreamy_Jazz	T310019 The Special:CheckUser block form should use OOUI
Resolved		Dreamy_Jazz	T266586 Use OOUI in SpecialCheckUserLog
			Restricted Task
Open	Feature	None	T26231 Allow CheckUsers to filter checks for account creations only
Resolved		Dreamy_Jazz	T139809 Bad output of AbuseFilter blocks in CU get edits
Open	BUG REPORT	None	T41013 Incomplete i18n for log entries in CheckUser
Resolved	BUG REPORT	Dreamy_Jazz	T268156 Partial blocks from namespaces are displayed odd
Open		None	T311354 Make CheckUser results easier to parse by userscripts
Open	Feature	None	T311380 Make certain types of edits in 'Get edits' highlightable for ease of parsing the results
Declined	Feature	None	T54849 Checkuser option "get users" should point out when user password is changed
Open	Feature	None	T315488 Show failed login attempts in the results list for the user
			Restricted Task
Open		Dreamy_Jazz	T145265 Store check user data action text in structured format
Open		None	T248926 Performance review of checkuser database queries [NOT READY]
Resolved		tstarling	T342613 CompareService::getTotalEditsFromIp queries exceeding TransactionProfiler limits
Open		None	T301992 Insert CheckUser row events during certain 2FA actions
Open		Tchanders	T326393 IP Address Reveal on Log page
In Progress		kostajh	T257893 [EPIC] Support User-Agent Client Hints header in CheckUser
Resolved		Dreamy_Jazz	T337942 Display client hint data
Resolved		Dreamy_Jazz	T340990 Display client hint data in Special:CheckUser's CheckUser helper table
Resolved		Dreamy_Jazz	T340991 Display client hint data in Special:CheckUser's 'Get users' mode
Open		None	T341094 Create client hint mapping rows for CheckUser-worthy events
Open	Feature	Dreamy_Jazz	T324907 Create separate tables for log events in CheckUser
Open		None	T341829 Enable read new for the event table migration
Open		None	T345818 Store client hint mapping rows for login events
Open		None	T345819 Store client hint mapping rows for logout events
Open		None	T345820 Store client hint mapping rows for password reset events
Open		None	T345821 Store client hint mapping rows for email user events
Open		None	T347393 Store client hint mapping rows for user account creations on loginwiki
Open		None	T345817 Store client hint mapping rows for user account creation events
Open		Dreamy_Jazz	T328992 Add read new support to Special:CheckUser for event table migration
Resolved		Dreamy_Jazz	T328997 Enable read new support in Special:CheckUser's 'Get users' mode

Event Timeline

Dreamy_Jazz created this task.Feb 7 2023, 12:56 AM

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptFeb 7 2023, 12:56 AM

Dreamy_Jazz updated the task description. (Show Details)Feb 7 2023, 12:56 AM

Change 884135 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Prepare CheckUserGetUsersPager for event table migration

https://gerrit.wikimedia.org/r/884135

gerritbot added a project: Patch-For-Review.Feb 7 2023, 1:00 AM

Dreamy_Jazz updated the task description. (Show Details)Feb 7 2023, 1:00 AM

Dreamy_Jazz moved this task from General / Unsorted to CheckUser on the CheckUser board.Feb 7 2023, 11:37 PM

Dreamy_Jazz triaged this task as High priority.Feb 8 2023, 11:58 PM

Change 884135 abandoned by Dreamy Jazz:

[mediawiki/extensions/CheckUser@master] Prepare CheckUserGetUsersPager for event table migration

Reason:

Replaced with Ia52d8ac125f902fa8549866816300d06327e1a5f

https://gerrit.wikimedia.org/r/884135

Dreamy_Jazz updated the task description. (Show Details)May 20 2023, 9:38 AM

Dreamy_Jazz added parent tasks: T340990: Display client hint data in Special:CheckUser's CheckUser helper table, T340991: Display client hint data in Special:CheckUser's 'Get users' mode.Jul 13 2023, 7:55 PM

Dreamy_Jazz renamed this task from Use the CheckUserUnionSelectQueryBuilder in Special:CheckUser's 'Get users' mode to Enable read new support in Special:CheckUser's 'Get users' mode.Sep 6 2023, 8:01 PM

Dreamy_Jazz updated the task description. (Show Details)

Change 955390 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] [WIP] Implement read new support for CheckUserGetUsersPager

https://gerrit.wikimedia.org/r/955390

Dreamy_Jazz added a project: Anti-Harassment (AHaT Sprint 32 - Baseball Cap).Sep 6 2023, 9:41 PM

Dreamy_Jazz moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.

Dreamy_Jazz mentioned this in T346044: Remove CheckUserUnionQueryBuilder.Sep 11 2023, 2:45 PM

Dreamy_Jazz moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.Sep 19 2023, 3:18 PM

Change 955390 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Implement read new support for CheckUserGetUsersPager

https://gerrit.wikimedia.org/r/955390

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.28; 2023-09-26).Sep 25 2023, 11:00 AM

Dreamy_Jazz updated the task description. (Show Details)Sep 25 2023, 10:54 PM

Suggested QA steps (requires a local instance to test):

Install the CheckUser extension
Check that no definition of $wgCheckUserEventTablesMigrationStage exists in your LocalSettings.php, and remove it if present.
Add $wgCheckUserLogLogins = true; into your LocalSettings.php if not already present
Create a few testing accounts
Make a few testing edits, log events (such as moves), and log in and out of the testing accounts
Log into an account with the checkuser right
Open Special:CheckUser, enter one account username you created in step 4 to the "Username" field, change the check subtype to 'Get IP Addresses', and then run a check.
Click on the IP address shown in the results list
Change the check type to 'Get users' on this new page and run the check
Verification step 1: Ensure you see the accounts you created in step 4 in the results list
Save a screenshot of the results for later comparison
Add $wgCheckUserEventTablesMigrationStage = SCHEMA_COMPAT_NEW; to your LocalSettings.php file
Press the check button on the 'Get users' check opened in step 9
Verification step 2: Verify that the results list did not visually change.

If QA needs suggested steps that work on patchdemo, please ping me and I will create them.

I compared the HTML output of "Get users" with SCHEMA_COMPAT_READ_OLD and SCHEMA_COMPAT_READ_NEW for all the IP addresses I had on my local wiki. There were no differences.

Test environment: local docker CheckUser 2.5 (d121f43) 16:23, 27 September 2023.

kostajh closed this task as Resolved.Sep 28 2023, 3:34 PM

Enable read new support in Special:CheckUser's 'Get users' modeClosed, ResolvedPublicActions