Enable read new support in Special:CheckUser's 'Get users' mode
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Dreamy_Jazz
	Feb 7 2023, 12:56 AM

Description

Now that CheckUser writes to the new tables for event table migration (T330158), reading from these tables when the migration stage is set to read new can commence.

This task is to add support to read new in Special:CheckUser's 'Get users' mode.

Acceptance criteria

Alias the current query info fields in CheckUserGetUsersPager to prepare for migration
Add code to read from the two new tables when reading new in CheckUserGetUsersPager

Details

	Subject	Repo	Branch	Lines +/-
	Implement read new support for CheckUserGetUsersPager	mediawiki/extensions/CheckUser	master	+222 -40
	Prepare CheckUserGetUsersPager for event table migration	mediawiki/extensions/CheckUser	master	+10 -8

Customize query in gerrit

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Assigned	Task
		· · ·
Resolved	Dreamy_Jazz	T328992 Add read new support to Special:CheckUser for event table migration
Resolved	Dreamy_Jazz	T340990 Display client hint data in Special:CheckUser's CheckUser helper table
Resolved	Dreamy_Jazz	T340991 Display client hint data in Special:CheckUser's 'Get users' mode
Resolved	Dreamy_Jazz	T328997 Enable read new support in Special:CheckUser's 'Get users' mode
		· · ·

Event Timeline

Dreamy_Jazz created this task.Feb 7 2023, 12:56 AM

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptFeb 7 2023, 12:56 AM

Dreamy_Jazz updated the task description. (Show Details)Feb 7 2023, 12:56 AM

Change 884135 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Prepare CheckUserGetUsersPager for event table migration

https://gerrit.wikimedia.org/r/884135

gerritbot added a project: Patch-For-Review.Feb 7 2023, 1:00 AM

Dreamy_Jazz updated the task description. (Show Details)Feb 7 2023, 1:00 AM

Dreamy_Jazz moved this task from General / Unsorted to CheckUser on the CheckUser board.Feb 7 2023, 11:37 PM

Dreamy_Jazz triaged this task as High priority.Feb 8 2023, 11:58 PM

Change 884135 abandoned by Dreamy Jazz:

[mediawiki/extensions/CheckUser@master] Prepare CheckUserGetUsersPager for event table migration

Reason:

Replaced with Ia52d8ac125f902fa8549866816300d06327e1a5f

https://gerrit.wikimedia.org/r/884135

Dreamy_Jazz updated the task description. (Show Details)May 20 2023, 9:38 AM

Dreamy_Jazz added parent tasks: T340990: Display client hint data in Special:CheckUser's CheckUser helper table, T340991: Display client hint data in Special:CheckUser's 'Get users' mode.Jul 13 2023, 7:55 PM

Dreamy_Jazz renamed this task from Use the CheckUserUnionSelectQueryBuilder in Special:CheckUser's 'Get users' mode to Enable read new support in Special:CheckUser's 'Get users' mode.Sep 6 2023, 8:01 PM

Dreamy_Jazz updated the task description. (Show Details)

Change 955390 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] [WIP] Implement read new support for CheckUserGetUsersPager

https://gerrit.wikimedia.org/r/955390

Dreamy_Jazz added a project: Anti-Harassment (AHaT Sprint 32 - Baseball Cap).Sep 6 2023, 9:41 PM

Dreamy_Jazz moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.

Dreamy_Jazz mentioned this in T346044: Remove CheckUserUnionQueryBuilder.Sep 11 2023, 2:45 PM

Dreamy_Jazz moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.Sep 19 2023, 3:18 PM

Change 955390 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Implement read new support for CheckUserGetUsersPager

https://gerrit.wikimedia.org/r/955390

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.28; 2023-09-26).Sep 25 2023, 11:00 AM

Dreamy_Jazz updated the task description. (Show Details)Sep 25 2023, 10:54 PM

Suggested QA steps (requires a local instance to test):

Install the CheckUser extension
Check that no definition of $wgCheckUserEventTablesMigrationStage exists in your LocalSettings.php, and remove it if present.
Add $wgCheckUserLogLogins = true; into your LocalSettings.php if not already present
Create a few testing accounts
Make a few testing edits, log events (such as moves), and log in and out of the testing accounts
Log into an account with the checkuser right
Open Special:CheckUser, enter one account username you created in step 4 to the "Username" field, change the check subtype to 'Get IP Addresses', and then run a check.
Click on the IP address shown in the results list
Change the check type to 'Get users' on this new page and run the check
Verification step 1: Ensure you see the accounts you created in step 4 in the results list
Save a screenshot of the results for later comparison
Add $wgCheckUserEventTablesMigrationStage = SCHEMA_COMPAT_NEW; to your LocalSettings.php file
Press the check button on the 'Get users' check opened in step 9
Verification step 2: Verify that the results list did not visually change.

If QA needs suggested steps that work on patchdemo, please ping me and I will create them.

I compared the HTML output of "Get users" with SCHEMA_COMPAT_READ_OLD and SCHEMA_COMPAT_READ_NEW for all the IP addresses I had on my local wiki. There were no differences.

Test environment: local docker CheckUser 2.5 (d121f43) 16:23, 27 September 2023.

kostajh closed this task as Resolved.Sep 28 2023, 3:34 PM

Enable read new support in Special:CheckUser's 'Get users' modeClosed, ResolvedPublicActions