Display client hint data in Special:CheckUser's CheckUser helper table
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Dreamy_Jazz
	Jul 3 2023, 1:53 PM

Description

Background information

Client hint data once collected should be displayed in Special:CheckUser. This data should be displayed in 'Get edits' and 'Get users' in the checkUserHelper table (checkUserHelper.js). An example of this table is shown below:

Design

The designs for the display of Client Hints data in this table were made in T345764: Design UI for displaying client hint data and the relevant design is shown below for reference:

Screenshot 2023-10-22 140728.png (697×1 px, 90 KB)

Acceptance criteria

Have Client Hints data be shown in the summary table in Special:CheckUser 'Get edits' and 'Get users'
Ensure this design is consistent with the designs made for this
Ensure the new design and display only occurs when Client Hints display is enabled.

QA Results - Local

AC	Status	Details
1	✅	https://phabricator.wikimedia.org/T340990 here

Details

	Subject	Repo	Branch	Lines +/-
	clienthints: Display data in Special:CheckUser summary table	mediawiki/extensions/CheckUser	master	+604 -145

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		kostajh	T257893 [EPIC] Support User-Agent Client Hints header in CheckUser
Resolved		Dreamy_Jazz	T337942 Display client hint data
Resolved		Dreamy_Jazz	T340990 Display client hint data in Special:CheckUser's CheckUser helper table
Resolved		Dreamy_Jazz	T328995 Enable read new support in Special:CheckUser's 'Get edits' mode
Resolved	BUG REPORT	Dreamy_Jazz	T347773 Log action text shown when reading new does not respect the deleted status of the log
Resolved		Dreamy_Jazz	T328997 Enable read new support in Special:CheckUser's 'Get users' mode
Resolved		Dreamy_Jazz	T348266 Test checkUserHelper.js
Resolved		Dreamy_Jazz	T345180 Implement JS testing in CheckUser

Event Timeline

Dreamy_Jazz renamed this task from Display client hint data in Special:CheckUser to Display client hint data in Special:CheckUser's CheckUser helper table.Jul 3 2023, 1:53 PM

Dreamy_Jazz created this task.

Dreamy_Jazz attached a referenced file: F37088501: image.png. (Show Details)

Dreamy_Jazz updated the task description. (Show Details)

Dreamy_Jazz updated the task description. (Show Details)Jul 3 2023, 2:08 PM

Dreamy_Jazz updated the task description. (Show Details)

Dreamy_Jazz moved this task from General / Unsorted to CheckUser on the CheckUser board.Jul 3 2023, 2:13 PM

Dreamy_Jazz added a project: Anti-Harassment.Jul 4 2023, 10:43 PM

Dreamy_Jazz added a subtask: T328995: Enable read new support in Special:CheckUser's 'Get edits' mode.Jul 13 2023, 7:54 PM

Dreamy_Jazz added a subtask: T328997: Enable read new support in Special:CheckUser's 'Get users' mode.

Dreamy_Jazz moved this task from Untriaged to CheckUser on the Anti-Harassment board.Jul 22 2023, 5:47 PM

Dreamy_Jazz moved this task from Backlog to Release 1 (all production wikis) on the http-client-hints board.Sep 26 2023, 12:01 PM

Dreamy_Jazz edited projects, added http-client-hints (Release 1 (all production wikis)); removed http-client-hints.

kostajh closed subtask T328997: Enable read new support in Special:CheckUser's 'Get users' mode as Resolved.Sep 28 2023, 3:34 PM

Dreamy_Jazz claimed this task.Oct 4 2023, 2:25 PM

Dreamy_Jazz edited projects, added Anti-Harassment (AHaT Sprint 32 - Baseball Cap); removed Anti-Harassment.

Dreamy_Jazz moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.

Dreamy_Jazz added a subtask: T348266: Test checkUserHelper.js.Oct 5 2023, 4:19 PM

Dreamy_Jazz updated the task description. (Show Details)Oct 6 2023, 2:56 PM

Change 964028 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] [WIP] clienthints: Display data in Special:CheckUser summary table

https://gerrit.wikimedia.org/r/964028

gerritbot added a project: Patch-For-Review.Oct 6 2023, 3:40 PM

kostajh closed subtask T328995: Enable read new support in Special:CheckUser's 'Get edits' mode as Resolved.Oct 9 2023, 8:02 AM

Further design work is being carried out to determine how to display the number of times the User-Agent and Client Hints are present in the results list. Therefore progress on this is halted until that point.

Dreamy_Jazz closed subtask T348266: Test checkUserHelper.js as Resolved.Oct 20 2023, 3:13 PM

Dreamy_Jazz updated the task description. (Show Details)Oct 22 2023, 1:09 PM

Dreamy_Jazz attached a referenced file: F37657176: Tables.png. (Show Details)

Dreamy_Jazz moved this task from Design Review 🔬 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.

• Niharika added a project: Trust and Safety Product Sprint.Oct 26 2023, 9:15 PM

Change 964028 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] clienthints: Display data in Special:CheckUser summary table

https://gerrit.wikimedia.org/r/964028

Dreamy_Jazz moved this task from Backlog to Sprint Bodhrán on the Trust and Safety Product Sprint board.Oct 30 2023, 4:41 PM

Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Bodhrán); removed Trust and Safety Product Sprint.

kostajh moved this task from Priority Backlog to Needs QA on the Trust and Safety Product Sprint (Sprint Bodhrán) board.Oct 30 2023, 4:42 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 30 2023, 5:10 PM

@Dreamy_Jazz Client Hint information is now shown in Special:CheckUser. I do have a couple of questions as seen below, before I move this to Done.

Status: ✅PASS
Environment: Local: 1.42.0-alpha (7637518) 20:02, 30 October 2023. CheckUser: 2.5 (84f2a55) 16:41, 30 October 2023
OS: macOS Sonoma 14.0
Browser: Chrome 117, Firefox 118, Safari 17.0
Skins. Vector 2022, 2010, Minerva, Monobook, Timeless
Device: MBA M2
Emulated Device:: n/a
Test Links:
http://localhost:8080/wiki/Special:CheckUser

✅AC1: https://phabricator.wikimedia.org/T340990

Old Patch	Latest Patch- Chrome	Firefox	Safari	Skins (Timeless)

Questions

What is the Brand that is highlighted? Is this fine? Also, the order when compared to the design from the description is ok, right?

2023-10-30_13-35-58.png (1×3 px, 548 KB)

When the IP address is XFF, is it supposed to have the Client Hints section empty?

2023-10-30_13-41-27.png (1×3 px, 373 KB)

GMikesell-WMF updated the task description. (Show Details)Oct 30 2023, 9:18 PM

In T340990#9293220, @GMikesell-WMF wrote:

Questions

What is the Brand that is highlighted? Is this fine? Also, the order when compared to the design from the description is ok, right?

This is called "grease data" and is added by browsers to reduce the ability for Client Hints data to be used for fingerprinting. Filtering this out automatically will be difficult as it's designed to be not filterable out.

When the IP address is XFF, is it supposed to have the Client Hints section empty?

The Client Hints data section shouldn't be empty for an XFF IP. Also to search by XFF IP, you need to add /xff at the end of the IP. That image shows results for users on that IP.

@Dreamy_Jazz Ok once I did an edit, the Client hints data was collected. We are good to go now. I will move this to Done. Thank you for all your work!

2023-10-30_16-45-02.png (1×3 px, 332 KB)

2023-10-30_16-50-53.png (1×3 px, 474 KB)

GMikesell-WMF moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Bodhrán) board.Oct 30 2023, 11:54 PM

kostajh closed this task as Resolved.Oct 31 2023, 7:03 AM

Display client hint data in Special:CheckUser's CheckUser helper tableClosed, ResolvedPublicActions