Page MenuHomePhabricator
Create Task
Maniphest T345180

Implement JS testing in CheckUser
Closed, ResolvedPublic
Actions

Description

There are several important JS files in CheckUser. Testing that these work as expected is an important step towards ensuring reliability of the code.

QUnit can be used to test these files without relying on end-to-end browser testing (such as selenium) which adds overhead.

Acceptance criteria
  • Have QUnit testing setup and ready for tests to be added in future commits.

Details

SubjectRepoBranchLines +/-
Add jest to package.json and add jest to CImediawiki/extensions/CheckUsermaster+9 K -50
Add QUnit test structure to CheckUsermediawiki/extensions/CheckUsermaster+38 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Dreamy_Jazz created this task.Aug 29 2023, 4:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 29 2023, 4:01 PM
Dreamy_Jazz added a project: JavaScript.Aug 29 2023, 4:01 PM
gerritbot added a comment.Aug 29 2023, 4:35 PM

Change 953309 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Add jest to package.json and add jest to CI

https://gerrit.wikimedia.org/r/953309

gerritbot added a project: Patch-For-Review.Aug 29 2023, 4:35 PM
Dreamy_Jazz added a project: Anti-Harassment (AHaT Sprint 32 - Baseball Cap).Aug 29 2023, 4:37 PM

I intend to look at testing the Client Hints module using jest.

Dreamy_Jazz claimed this task.Aug 29 2023, 4:37 PM
Dreamy_Jazz moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.
Dreamy_Jazz moved this task from Code Review 🔍 to In Progress 💪 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.Aug 30 2023, 10:53 PM
Dreamy_Jazz edited projects, added Anti-Harassment; removed Anti-Harassment (AHaT Sprint 32 - Baseball Cap).Sep 13 2023, 4:21 PM
gerritbot added a comment.Oct 5 2023, 10:44 AM

Change 955322 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] [WIP] Add QUnit test structure to CheckUser

https://gerrit.wikimedia.org/r/955322

gerritbot added a comment.Oct 5 2023, 11:31 AM

Change 955322 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] [WIP] Add QUnit test structure to CheckUser

https://gerrit.wikimedia.org/r/955322

Dreamy_Jazz edited projects, added Anti-Harassment (AHaT Sprint 32 - Baseball Cap); removed Anti-Harassment.Oct 5 2023, 11:32 AM
Dreamy_Jazz moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.
Dreamy_Jazz updated the task description. (Show Details)Oct 5 2023, 4:13 PM
Dreamy_Jazz added a parent task: T348266: Test checkUserHelper.js.Oct 5 2023, 4:18 PM
gerritbot added a comment.Oct 6 2023, 1:07 PM

Change 955322 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Add QUnit test structure to CheckUser

https://gerrit.wikimedia.org/r/955322

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.30; 2023-10-10).Oct 6 2023, 2:00 PM
gerritbot added a comment.Oct 8 2023, 9:44 PM

Change 953309 abandoned by Dreamy Jazz:

[mediawiki/extensions/CheckUser@master] Add jest to package.json and add jest to CI

Reason:

https://gerrit.wikimedia.org/r/953309

Dreamy_Jazz closed this task as Resolved.Oct 20 2023, 3:12 PM
Dreamy_Jazz updated the task description. (Show Details)
Dreamy_Jazz moved this task from Code Review 🔍 to Done Q1 2023-2024 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL