Page MenuHomePhabricator
Create Task
Maniphest T328992

Add read new support to Special:CheckUser for event table migration
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Now that CheckUser writes to the new tables for event table migration (T330158), reading from these tables when the migration stage is set to read new can commence in Special:CheckUser

This task is a parent task to tasks that will add read new support for each of the three check types in Special:CheckUser.

Acceptance criteria
  • Code to support reading new is added to AbstractCheckUserPager
  • Read new support is implemented in 'Get IP addresses'
  • Read new support is implemented in 'Get edits'
  • Read new support is implemented in 'Get users'

Details

SubjectRepoBranchLines +/-
Implement read new support for CheckUserGetEditsPagermediawiki/extensions/CheckUsermaster+1 K -224
Prepare CheckUser pagers for event table migrationmediawiki/extensions/CheckUsermaster+110 -96
Pass CheckUserUnionSelectQueryBuilderFactory to the CheckUser pagersmediawiki/extensions/CheckUsermaster+37 -9
Customize query in gerrit

Related Objects
Search...

Event Timeline

Dreamy_Jazz created this task.Feb 7 2023, 12:38 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 7 2023, 12:38 AM
Dreamy_Jazz updated the task description. (Show Details)Feb 7 2023, 12:38 AM
gerritbot added a comment.Feb 7 2023, 12:41 AM

Change 884130 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Pass CheckUserUnionSelectQueryBuilderFactory to the CheckUser pagers

https://gerrit.wikimedia.org/r/884130

gerritbot added a project: Patch-For-Review.Feb 7 2023, 12:41 AM
Dreamy_Jazz added a subtask: T328988: Create a SelectQueryBuilder that allows selecting from all three tables.Feb 7 2023, 12:59 AM
Dreamy_Jazz moved this task from General / Unsorted to CheckUser on the CheckUser board.Feb 7 2023, 11:37 PM
Dreamy_Jazz triaged this task as High priority.Feb 8 2023, 11:57 PM
gerritbot added a comment.Apr 9 2023, 1:10 PM

Change 884130 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Pass CheckUserUnionSelectQueryBuilderFactory to the CheckUser pagers

https://gerrit.wikimedia.org/r/884130

Maintenance_bot removed a project: Patch-For-Review.Apr 9 2023, 1:30 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.4; 2023-04-10).Apr 9 2023, 2:00 PM
Dreamy_Jazz closed subtask T328988: Create a SelectQueryBuilder that allows selecting from all three tables as Resolved.Apr 23 2023, 2:12 PM
gerritbot added a comment.May 19 2023, 2:06 PM

Change 921358 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Prepare CheckUser pagers for event table migration

https://gerrit.wikimedia.org/r/921358

gerritbot added a project: Patch-For-Review.May 19 2023, 2:06 PM
gerritbot added a comment.May 20 2023, 8:24 AM

Change 921358 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Prepare CheckUser pagers for event table migration

https://gerrit.wikimedia.org/r/921358

Maintenance_bot removed a project: Patch-For-Review.May 20 2023, 8:31 AM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.10; 2023-05-23); removed MW-1.41-notes (1.41.0-wmf.4; 2023-04-10).May 20 2023, 9:00 AM
Dreamy_Jazz added a parent task: T341829: Enable read new for the event table migration.Jul 13 2023, 8:03 PM
Dreamy_Jazz renamed this task from Use CheckUserUnionSelectQueryBuilder in Special:CheckUser to Add read new support to Special:CheckUser for event table migration.Sep 5 2023, 11:47 AM
Dreamy_Jazz updated the task description. (Show Details)
Dreamy_Jazz added a project: Anti-Harassment (AHaT Sprint 32 - Baseball Cap).
Dreamy_Jazz moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.
Dreamy_Jazz updated the task description. (Show Details)
gerritbot added a comment.Sep 5 2023, 11:49 AM

Change 954051 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Implement read new support for CheckUserGetEditsPager

https://gerrit.wikimedia.org/r/954051

gerritbot added a project: Patch-For-Review.Sep 5 2023, 11:49 AM
gerritbot added a comment.Sep 14 2023, 7:55 PM

Change 954051 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Implement read new support for CheckUserGetEditsPager

https://gerrit.wikimedia.org/r/954051

Maintenance_bot removed a project: Patch-For-Review.Sep 14 2023, 8:10 PM
kostajh closed subtask T328997: Enable read new support in Special:CheckUser's 'Get users' mode as Resolved.Sep 28 2023, 3:34 PM
kostajh closed subtask T328995: Enable read new support in Special:CheckUser's 'Get edits' mode as Resolved.Oct 9 2023, 8:02 AM
Dreamy_Jazz added a subtask: T345818: Store client hint mapping rows for login events.Oct 22 2023, 1:12 PM
Dreamy_Jazz added a subtask: T345817: Store client hint mapping rows for user account creation events.
Dreamy_Jazz added a subtask: T345819: Store client hint mapping rows for logout events.
Dreamy_Jazz added a subtask: T347393: Store client hint mapping rows for user account creations on loginwiki.Oct 22 2023, 1:18 PM
Dreamy_Jazz removed a subtask: T347393: Store client hint mapping rows for user account creations on loginwiki.
Dreamy_Jazz added a parent task: T347393: Store client hint mapping rows for user account creations on loginwiki.
Dreamy_Jazz removed a subtask: T345817: Store client hint mapping rows for user account creation events.
Dreamy_Jazz added a parent task: T345817: Store client hint mapping rows for user account creation events.
Dreamy_Jazz removed a subtask: T345819: Store client hint mapping rows for logout events.
Dreamy_Jazz removed a subtask: T345818: Store client hint mapping rows for login events.
Dreamy_Jazz added a parent task: T345819: Store client hint mapping rows for logout events.Oct 22 2023, 1:20 PM
Dreamy_Jazz added a parent task: T345818: Store client hint mapping rows for login events.
Dreamy_Jazz added projects: Trust and Safety Product Team, Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)).Nov 17 2023, 1:09 PM
Dreamy_Jazz set the point value for this task to 1.Nov 20 2023, 4:23 PM
Dreamy_Jazz closed this task as Resolved.Dec 11 2023, 5:20 PM
Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Lute (11th Dec. - 22nd Dec. 2023)); removed Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)).
Dreamy_Jazz updated the task description. (Show Details)

Started to enable read new on WMF wikis. Only open subtask is just waiting for QA and has been for a while. Closing this as resolved.

Dreamy_Jazz closed subtask T328998: Enable read new support in Special:CheckUser's 'Get IP Addresses' mode as Resolved.Dec 18 2023, 2:47 PM
Dreamy_Jazz added a parent task: T366505: Stop writing old for event table migration in extension.json.Tue, Jun 4, 4:17 PM
Dreamy_Jazz removed a parent task: T324907: Create separate tables for log events in CheckUser.Wed, Jun 5, 4:46 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL