Page MenuHomePhabricator

Look into issues with the QInominator not beeing able to insert selections
Closed, ResolvedPublic

Description

A wish from the Reparatursommer board. ( See wiki )

The QInominator is a Gadget on Wikimedia Commons to provide an simple UI to select and insert the pictures that should be candidates for the quality images category.

When browsing images the gadget offers an option to "remember" an image as candidate. This seems to work.
When the user is happy with the selection they can go to the candidates page, open it in a Wikitext editor and the gadget then offers another option to insert the selection as wikitext. This seems to be broken.

Ressources:

Note:
I already copied the current version of the Gadget to the beta cluster and it can be enabled in the user settings.

Event Timeline

First tests: Seems to be working fine when using the classic WikiEditor (2010) and I think there's no VisualEditor wikitext editor (2017) available. So the issue might be with certain images only...

What I did:

Add to gadget.png (55×595 px, 18 KB)

Add to edit.png (28×339 px, 9 KB)

  • Wiki text is added to the editor and can be reviewed with Show changes

Note: Don't save if here you don't want to mess up things :-).

Seems, there's an issue when using syntax highlighting. :-)

I updated the patch to also include the 2nd place where changing the textbox content might be relevant. This is mainly affecting the QIvoter part of the script. The voter part would need way more love though it seems so I stopped with the main issue fixing the QInominator.

https://commons.wikimedia.beta.wmflabs.org/w/index.php?title=MediaWiki%3AQIvoter.js&diff=290947&oldid=290825

Can be tested on the beta cluster. Browse random files, add them to your "bucket" and then edit https://commons.wikimedia.beta.wmflabs.org/wiki/Commons:Quality_images_candidates/candidate_list and them there with the green button.

I left a note on the QIvoter Gadget help page with a hint to the syntax highlighting incompatibility. https://commons.wikimedia.org/w/index.php?title=Help%3AGadget-QIvoter&diff=784687663&oldid=130861000

Handover for further working on this: If the code seems fine, an interface admin could copy the code from https://commons.wikimedia.beta.wmflabs.org/wiki/MediaWiki:QIvoter.js to https://commons.wikimedia.org/wiki/MediaWiki:QIvoter.js to deploy it. I saw @Lucas_Werkmeister_WMDE editing that file in the history. ;-)

Done, though an edit request is usually the better way to get the attention of interface admins.