Remove script to convert Phabricator parent project into subproject
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Aklapper
	Jul 19 2023, 4:19 PM

Description

We added this script in T221112: Document how to convert projects into subprojects/milestones etc (sudo privileges for phab admins to run move_project script).
We should not use this script and thus should not perform this action. The script

does not remove parent project tag when project to convert becomes that parent project's subproject
has an unknown bug which makes projects inaccessible, see T177787#9023514, which also made a milestone disappear from a workboard

I don't like creating DB inconsistencies and making stuff inaccessible. Thus

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	admin: Remove `bin/move_project` from phabricator-admin privileges	operations/puppet	production	+0 -2

Customize query in gerrit

Related Objects

Mentioned In: T409193: Deploy Phab/Phorge 2025-11-04
T369077: Convert GrowthExperiments-Community-Updates to be a subproject of GrowthExperiments
T345563: Call to a member function updateDatasourceTokens() on null at PhabricatorProjectFulltextEngine.php:20 (due to DB corruption)
T242254: move_project breaks the world when moving a subproject that already has subprojects.
T253214: Extend move_project.php to allow moving child projects
T224421: move_project script does not check if task is in both future parent and future subproject and does not remove future parent project
T123425: [EPIC] Make wikitech more friendly for the multiple audiences it supports
Mentioned Here: T177787: Organize additional projects as #cloud-services subprojects
T221112: Document how to convert projects into subprojects/milestones etc (sudo privileges for phab admins to run move_project script)

Event Timeline

Aklapper created this task.Jul 19 2023, 4:19 PM

Aklapper triaged this task as Medium priority.

Aklapper mentioned this in T123425: [EPIC] Make wikitech more friendly for the multiple audiences it supports.Aug 22 2023, 9:49 AM

RhinosF1 subscribed.Aug 22 2023, 11:36 AM

epicpupper opened https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/18

Delete buggy script

Frostly added a project: User-Frostly.Oct 2 2023, 8:51 PM

Frostly subscribed.

Frostly moved this task from Backlog to For review on the User-Frostly board.Oct 3 2023, 4:43 AM

Aklapper mentioned this in T224421: move_project script does not check if task is in both future parent and future subproject and does not remove future parent project.Nov 27 2023, 3:13 PM

Applied delete from the merge request at:

https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/commit/03e1cc54b1264f76543163d7f693671bef6f9315

brennen closed https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/18

Delete buggy script

May be lingering documentation cleanup here after script deletion.

Maintenance_bot removed a project: Patch-For-Review.Apr 15 2024, 7:31 PM

Deployed on 2024-04-16

Aklapper mentioned this in T253214: Extend move_project.php to allow moving child projects.Apr 21 2024, 3:15 PM

Aklapper mentioned this in T242254: move_project breaks the world when moving a subproject that already has subprojects..

Aklapper mentioned this in T345563: Call to a member function updateDatasourceTokens() on null at PhabricatorProjectFulltextEngine.php:20 (due to DB corruption).Apr 29 2024, 11:35 AM

Aklapper mentioned this in T369077: Convert GrowthExperiments-Community-Updates to be a subproject of GrowthExperiments.Jul 3 2024, 5:38 AM

asmartkitten opened https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/101

Delete bin/move_project

Change #1189974 had a related patch set uploaded (by A smart kitten; author: A smart kitten):

[operations/puppet@production] admin: Remove `bin/move_project` from phabricator-admin privileges

https://gerrit.wikimedia.org/r/1189974

A_smart_kitten subscribed.Sep 21 2025, 4:22 PM

Mentioned in SAL (#wikimedia-operations) [2025-09-24T20:56:49Z] <mutante> phab1004/phab2002 - unlink /srv/phab/phabricator/bin/move_project (broken symbolic link to ../scripts/move_beneath.php) T342275