Maniphest T342392

Label: <legend> must be a direct child of <fieldset>
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	AnneT
	Jul 20 2023, 8:40 PM

Tags

Referenced Files

None

Subscribers

Description

Assistive technology does not read the legend for fieldsets, so users will not know the label or description for the group as a whole. Currently, the Label componet outputs a div that contains either a <label> or <legend> element, and the legend is not read by a screen reader when entering a fieldset via keyboard.

The Label element wraps the legend or label element in a div. This is necessary for the label, which does not contain the description text (it appears below the label in a separate element). However, for the legend, the description is included in the legend element, and this should be the root element output by Label.

Acceptance criteria

Label is refactored so that, when isLegend is true, the <legend> element is the root element of the component. The output for a label when isLegend is false should not change.
legend is read by a screen reader when entering a fieldset

Details

	Subject	Repo	Branch	Lines +/-
	Label: Make <legend> the root element	design/codex	main	+752 -807
	Update Codex from v0.15.0 to v0.16.1	mediawiki/core	master	+1 K -1 K

Customize query in gerrit

Event Timeline

AnneT created this task.Jul 20 2023, 8:40 PM

Restricted Application added a project: Design-System-Team. · View Herald TranscriptJul 20 2023, 8:40 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

CCiufo-WMF set the point value for this task to 2.Jul 20 2023, 8:48 PM

CCiufo-WMF moved this task from Inbox to Needs Refinement on the Design-System-Team board.Jul 21 2023, 12:57 AM

CCiufo-WMF triaged this task as High priority.Jul 24 2023, 4:10 PM

CCiufo-WMF moved this task from Needs Refinement to Up Next on the Design-System-Team board.

CCiufo-WMF added a project: Accessibility.Jul 24 2023, 4:15 PM

egardner moved this task from Up Next to Design-Systems-Sprint-4 on the Design-System-Team board.Jul 24 2023, 5:14 PM

egardner edited projects, added Design-System-Team (Design-Systems-Sprint-4); removed Design-System-Team.

AnneT claimed this task.Jul 24 2023, 7:44 PM

AnneT moved this task from Committed to In Progress on the Design-System-Team (Design-Systems-Sprint-4) board.Jul 25 2023, 12:56 PM

Change 941447 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[design/codex@main] Label: Make <legend> the root element

https://gerrit.wikimedia.org/r/941447

gerritbot added a project: Patch-For-Review.Jul 25 2023, 3:51 PM

AnneT moved this task from In Progress to Code Review on the Design-System-Team (Design-Systems-Sprint-4) board.Jul 25 2023, 4:10 PM

Catrope moved this task from Code Review to Pending Release on the Design-System-Team (Design-Systems-Sprint-4) board.Jul 25 2023, 7:10 PM

Change 941447 merged by jenkins-bot:

[design/codex@main] Label: Make <legend> the root element

https://gerrit.wikimedia.org/r/941447

Maintenance_bot removed a project: Patch-For-Review.Jul 25 2023, 7:31 PM

Change 944353 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] Update Codex from v0.15.0 to v0.16.1

https://gerrit.wikimedia.org/r/944353

gerritbot added a project: Patch-For-Review.Aug 1 2023, 11:29 PM

Change 944353 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v0.15.0 to v0.16.1

https://gerrit.wikimedia.org/r/944353

Maintenance_bot removed a project: Patch-For-Review.Aug 2 2023, 7:30 AM

Volker_E updated the task description. (Show Details)Aug 2 2023, 8:48 AM

Volker_E closed this task as Resolved.Aug 2 2023, 9:11 AM

Volker_E updated the task description. (Show Details)