Page MenuHomePhabricator
Create Task
Maniphest T342527

Lexeme CI PHPUnit tests broken
Closed, ResolvedPublic
Actions

Description

12:01:48 1) Wikibase\Lexeme\Tests\MediaWiki\Api\AddFormTest::testRateLimitIsCheckedWhenEditing
12:01:48 Failed asserting that two strings are equal.
12:01:48 --- Expected
12:01:48 +++ Actual
12:01:48 @@ @@
12:01:48 -'actionthrottledtext'
12:01:48 +'apierror-ratelimited'
12:01:48 
12:01:48 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/mediawiki/Api/AddFormTest.php:53
12:01:48 /workspace/src/tests/phpunit/includes/api/ApiTestCase.php:277
12:01:48 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:527

from: https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php81-noselenium-docker/15813/console

Caused by Implement rate limiting in Authority. (Ic349f03b)

Acceptance Criteria:

  • Lexeme CI is no longer failing on master
  • The skipped tests are reenabled and adjusted as needed

Details

SubjectRepoBranchLines +/-
Reenable and adjust API rate-limiting tests for new messagemediawiki/extensions/WikibaseLexememaster+6 -12
Temporarily disable rate-limit testsmediawiki/extensions/WikibaseLexememaster+6 -0
Customize query in gerrit

Related Objects

Event Timeline

Michael created this task.Jul 24 2023, 10:34 AM

Implement rate limiting in Authority. (Ic349f03b) has DEPLOY: Risky! in its commit message, so we will disabled those tests for now and reenable them after next week's train, once we know that there are no issues with the core change.

gerritbot added a comment.Jul 24 2023, 10:42 AM

Change 940885 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/WikibaseLexeme@master] Temporarily disable rate-limit tests

https://gerrit.wikimedia.org/r/940885

gerritbot added a project: Patch-For-Review.Jul 24 2023, 10:42 AM
Michael claimed this task.Jul 24 2023, 10:44 AM
Michael triaged this task as Unbreak Now! priority.
Michael added a project: Wikidata Dev Team (Sprint-∞).

UBN as Lexeme build failures on master prevent multiple teams from merging their code.

Restricted Application added a project: User-Michael. · View Herald TranscriptJul 24 2023, 10:44 AM
WMDE-leszek subscribed.Jul 24 2023, 10:46 AM
Michael updated the task description. (Show Details)Jul 24 2023, 10:46 AM
Michael moved this task from Parents/Waiting to Peer Review on the Wikidata Dev Team (Sprint-∞) board.
gerritbot added a comment.Jul 24 2023, 11:04 AM

Change 940885 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Temporarily disable rate-limit tests

https://gerrit.wikimedia.org/r/940885

Michael changed the task status from Open to Stalled.Jul 24 2023, 11:08 AM
Michael lowered the priority of this task from Unbreak Now! to Needs Triage.
Michael moved this task from Peer Review to Parents/Waiting on the Wikidata Dev Team (Sprint-∞) board.

We should fix and re-enable those tests after Implement rate limiting in Authority. (Ic349f03b) is known to be stable in production. So, probably after the train next week, likely on Thursday (=August 3rd).

Maintenance_bot removed a project: Patch-For-Review.Jul 24 2023, 11:10 AM
Michael removed Michael as the assignee of this task.Jul 24 2023, 11:12 AM
Tarrow subscribed.Jul 24 2023, 11:25 AM

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/939251 is all happily merged now. Temporary test skipping confirmed to have fixed the blockage

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.19; 2023-07-25).Jul 24 2023, 12:00 PM
Michael updated the task description. (Show Details)Jul 24 2023, 1:50 PM
Lucas_Werkmeister_WMDE subscribed.Jul 31 2023, 1:15 PM
Michael changed the task status from Stalled to Open.Aug 2 2023, 4:46 PM
Michael claimed this task.
Michael moved this task from incoming to in progress on the Wikidata board.

I do not see a revert and also T310476 looks fine, so I think we can start to prepare the proper fix now.

gerritbot added a comment.Aug 2 2023, 4:56 PM

Change 944964 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/WikibaseLexeme@master] Reenable and adjust API rate-limiting tests for new message

https://gerrit.wikimedia.org/r/944964

gerritbot added a project: Patch-For-Review.Aug 2 2023, 4:56 PM
Michael moved this task from Parents/Waiting to Doing on the Wikidata Dev Team (Sprint-∞) board.Aug 2 2023, 4:58 PM
Michael moved this task from Doing to Peer Review on the Wikidata Dev Team (Sprint-∞) board.Aug 2 2023, 5:15 PM
gerritbot added a comment.Aug 4 2023, 9:07 AM

Change 944964 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Reenable and adjust API rate-limiting tests for new message

https://gerrit.wikimedia.org/r/944964

Maintenance_bot removed a project: Patch-For-Review.Aug 4 2023, 9:10 AM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.22; 2023-08-15); removed MW-1.41-notes (1.41.0-wmf.19; 2023-07-25).Aug 4 2023, 10:00 AM
Michael closed this task as Resolved.Aug 7 2023, 2:42 PM
Michael updated the task description. (Show Details)
Michael moved this task from Peer Review to Our work done on the Wikidata Dev Team (Sprint-∞) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL