Breaking down T340138, this task proposes to add an ellipsis/action menu next to each individual comment both on mobile and desktop.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| overflow menu: Display next to comments on desktop | mediawiki/extensions/DiscussionTools | master | +49 -53 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T337566 [EPIC]: Incident Reporting System - Minimal Testable Product (MTP) | |||
| Resolved | kostajh | T339247 [Sub-epic] Create entry points for the Incident Report dialog with DiscussionTools | |||
| Open | None | T338534 Generate a design that accommodates multiple comment- and topic-level actions | |||
| Resolved | kostajh | T340138 Add ellipsis / action menu to topic headers and individual comments | |||
| Resolved | kostajh | T342625 Add ellipsis menu at comment level on mobile/desktop |
Event Timeline
Comment Actions
Change 965151 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):
[mediawiki/extensions/DiscussionTools@master] overflow menu: Display next to comments on desktop
Comment Actions
Change 965151 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] overflow menu: Display next to comments on desktop
Comment Actions
Example from mobile https://ko.m.wikipedia.beta.wmflabs.org/w/index.php?title=%EC%82%AC%EC%9A%A9%EC%9E%90%ED%86%A0%EB%A1%A0:Bluedot&uselang=en
Example from desktop
Note that on desktop, you need to enable DiscussionTools as beta feature for your account:
Comment Actions
Test wiki created on Patch demo by DJacksonA using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/1d5ea690f0/w
Comment Actions
Test wiki created on Patch demo by DJacksonA using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/6740a8095e/w
Comment Actions
Test wiki on Patch demo by DJacksonA using patch(es) linked to this task was deleted:
Comment Actions
I was able to confirm in Mobile View and Desktop View the ellipsis menu is displaying at the Comment level, and the Report option is displaying and functioning as expected.
Great Job @kostajh, and thank you for the comparison screenshots for Mobile and Desktop views.
Testing was executed at the following urls:
https://ko.wikipedia.beta.wmflabs.org/wiki/%EC%82%AC%EC%9A%A9%EC%9E%90%ED%86%A0%EB%A1%A0:Bluedot?uselang=en
https://patchdemo.wmflabs.org/wikis/6740a8095e/w/index.php?title=User_talk:Patch_Demo&action=edit&redlink=1
Screenshots for Report option displaying in Comments Thread on User Talk page with Desktop View:
Screenshots for Report option displaying in Comments Thread on User Talk page with Mobile View:
Comment Actions
Test wiki on Patch demo by DJacksonA using patch(es) linked to this task was deleted: