Page MenuHomePhabricator

Add ellipsis / action menu to topic headers and individual comments
Closed, ResolvedPublic

Description

Note: this is somewhat blocked by T338534: Generate a design that accommodates multiple comment- and topic-level actions, though from initial conversations with @ppelberg and @Esanders it's my understanding that an ellipsis overflow menu seems likely.

In a DiscussionTools page, we have topic headers and then individual comments. Next to each individual comment is a reply button. This task proposes to add an ellipsis menu next to each topic header and comment.

The menu should have a server-side hook that passes data about the topic header ID / text and comment ID / text so that extensions can add relevant items to the menu. The items would have a CSS class and optional URL.

Notes:

  • It is probably easier to fire the hook once per comment than to fire the hook with hundreds of objects in a parameter
  • DiscussionTools should not render the ellipsis menu if the hook doesn't yield any newly registered menu items

References:

Related Objects

Event Timeline

kostajh renamed this task from add an overflow menu to Add overflow menu to topic headers and individual comments.Jul 6 2023, 2:38 PM
kostajh updated the task description. (Show Details)
kostajh updated the task description. (Show Details)
kostajh added subscribers: ppelberg, Esanders.
kostajh renamed this task from Add overflow menu to topic headers and individual comments to Add ellipsis / action menu to topic headers and individual comments.Jul 6 2023, 2:46 PM
kostajh updated the task description. (Show Details)
kostajh subscribed.

As per the discussion yesterday with @eigyan and @JKieserman we are breaking down this ticket in:

  • T342623 Add ellipsis menu to topic header on mobile
  • T342625 Add ellipsis menu at comment level on mobile/desktop
  • T342627 Add ellipsis menu to topic header on desktop

Change 961748 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[integration/config@master] zuul: Require DiscussionTools in phan deps for ReportIncident

https://gerrit.wikimedia.org/r/961748

Change 961748 merged by jenkins-bot:

[integration/config@master] zuul: Require DiscussionTools in phan deps for ReportIncident

https://gerrit.wikimedia.org/r/961748

Change 961816 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[integration/config@master] zuul: Require DiscussionTools for ReportIncident

https://gerrit.wikimedia.org/r/961816

Change 961816 merged by jenkins-bot:

[integration/config@master] zuul: Require DiscussionTools for ReportIncident

https://gerrit.wikimedia.org/r/961816

Closing this one as it isn't very useful on its own; remaining work is in T342627: Add ellipsis menu to topic header on desktop