Page MenuHomePhabricator

Do not display CreateObject form if user does not have right to create ZObject
Closed, ResolvedPublic

Description

Reproduce: https://www.wikifunctions.org/wiki/Special:CreateObject

Expected: This will display something similar to https://www.wikidata.org/wiki/Special:NewProperty in an anonymous tab (Permission error).

Event Timeline

Change 942693 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Special:CreateObject: Restrict rights to 'wikilambda-create' not 'createpage' right

https://gerrit.wikimedia.org/r/942693

Jdforrester-WMF changed the task status from Open to In Progress.Jul 28 2023, 5:02 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF moved this task from Backlog to In Progress on the Abstract Wikipedia team board.

Change 942693 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Special:CreateObject: Restrict rights to 'wikilambda-create' not 'createpage' right

https://gerrit.wikimedia.org/r/942693

Etonkovidova subscribed.

Checked on wikifunctions beta:

Screen Shot 2023-08-04 at 12.42.02 PM.png (592×2 px, 89 KB)

Note: the links on wikidata refer to the documentation in Wikidata namespace, e.g. https://www.wikidata.org/wiki/Wikidata:Administrators. On wikifunctions beta, red links look as follows: https://wikifunctions.beta.wmflabs.org/w/index.php?title=Functioneers&action=edit&redlink=1

Still not deployed until the next train.

Yes, so we keep tasks in To deploy column to indicate what tasks will go to production? Usually, Verify in production column means that all work (testing and dev work) is finished and the fix only needs to be checked in production.

Still not deployed until the next train.

Yes, so we keep tasks in To deploy column to indicate what tasks will go to production? Usually, Verify in production column means that all work (testing and dev work) is finished and the fix only needs to be checked in production.

Yes, that was the plan – I was suggesting that "To deploy" means wait for the next deploy window (e.g. config) or train (regular patch), or backport (if needed); "Verify in Prod" means "this is now live and should be signed off or trigger re-work".

As said this week, these columns are likely to change, as we adjust to them.

Still not deployed until the next train.

Yes, so we keep tasks in To deploy column to indicate what tasks will go to production? Usually, Verify in production column means that all work (testing and dev work) is finished and the fix only needs to be checked in production.

Yes, that was the plan – I was suggesting that "To deploy" means wait for the next deploy window (e.g. config) or train (regular patch), or backport (if needed); "Verify in Prod" means "this is now live and should be signed off or trigger re-work".

As said this week, these columns are likely to change, as we adjust to them.

Thank you, @Jdforrester-WMF for clarification!

Checked on wikifunctions wmf.28 for anon and users without create object rights - the error message is in place; the error message page permission error page -Special:CreateObject looks similar to permission error page - wikidata Special:NewProperty.

Screen Shot 2023-09-27 at 4.22.00 PM.png (952×2 px, 287 KB)