Page MenuHomePhabricator

LabelledSectionTransclusion CI parser tests broken
Closed, ResolvedPublicBUG REPORT

Description

Per https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php74-noselenium-docker/116269/console

This causing ProofreadPage and Wikimedia OCR (the extension) CI to fail with the following error:

12:33:38 There was 1 failure:
12:33:38 
12:33:38 1) ParserIntegrationTest::testParse with data set "lstParserTest.txt: LST: verify self-inclusion fails" ('legacy')
12:33:38 Failed asserting that two strings are equal.
12:33:38 --- Expected
12:33:38 +++ Actual
12:33:38 @@ @@
12:33:38  '<p>Section A begin\n
12:33:38 -</p><p>Section B begin\n
12:33:38 -<span class="error">Template loop detected: <a href="/wiki/Lst-selfinclusion1" title="Lst-selfinclusion1">Lst-selfinclusion1</a></span>\n
12:33:38 -Section B end\n
12:33:38 -</p><p>Section A end\n
12:33:38 +<a href="/index.php?title=Lst-selfinclusion2&amp;action=edit&amp;redlink=1" class="new" title="Lst-selfinclusion2 (page does not exist)">Lst-selfinclusion2</a>\n
12:33:38 +Section A end\n
12:33:38  </p>'
12:33:38 
12:33:38 /workspace/src/tests/phpunit/suites/ParserIntegrationTest.php:68
12:33:38 /workspace/src/tests/phpunit/suites/SuiteEventsTrait.php:69
12:33:38 /workspace/src/tests/phpunit/suites/SuiteEventsTrait.php:69
12:33:38 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97
12:33:38 === Logs generated by test case
12:33:38 [wfDebug] [debug] ParserTestRunner::runLegacyTest: running LST: verify self-inclusion fails {"private":false}
12:33:38 [wfDebug] [debug] ParserFactory: using default preprocessor {"private":false}
12:33:38 ===
12:33:38 
12:33:38 FAILURES!
12:33:38 Tests: 5600, Assertions: 24108, Failures: 1, Skipped: 92.
12:33:38

Event Timeline

Soda triaged this task as High priority.Jul 27 2023, 1:43 PM

Triaging to high since this is/will block(ing) CI for anything that depends on it

Change 942515 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] tests: Reset title cache after page creation in ParserTestRunner

https://gerrit.wikimedia.org/r/942515

Change 942515 merged by jenkins-bot:

[mediawiki/core@master] tests: Reset title cache after page creation in ParserTestRunner

https://gerrit.wikimedia.org/r/942515

Umherirrender claimed this task.