Page MenuHomePhabricator
Create Task
Maniphest T343243

Migrate ArticleUndelete to PageUndeleteComplete in PageTriage
Closed, ResolvedPublic
Actions

Description

One hypothesis we have for the parent task bug T315591: Regression: Undeleted mainspace articles are not added to the PageTriage queue, relates to the ArticleUndelete hook potentially causing race conditions. We could try migrating to the newer PageUndeleteComplete to see if this helps.

Details

SubjectRepoBranchLines +/-
Change WikiPage creation in onPageUndeleteCompletemediawiki/extensions/PageTriagemaster+17 -6
Migrate to onPageUndeleteCompletemediawiki/extensions/PageTriagemaster+27 -58
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Samwalton9-WMF created this task.Aug 1 2023, 3:50 PM
Scardenasmolinar changed the task status from Open to In Progress.Aug 1 2023, 5:32 PM
Scardenasmolinar claimed this task.
Scardenasmolinar moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.
gerritbot added a comment.Aug 2 2023, 3:10 AM

Change 944358 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/extensions/PageTriage@master] [WIP] Migrate to onPageUndeleteComplete

https://gerrit.wikimedia.org/r/944358

gerritbot added a project: Patch-For-Review.Aug 2 2023, 3:10 AM
Scardenasmolinar moved this task from In Progress to Code review on the Moderator-Tools-Team (Kanban) board.Aug 2 2023, 6:22 PM
Scardenasmolinar moved this task from Backlog to Code Review on the PageTriage board.
gerritbot added a comment.Aug 2 2023, 7:35 PM

Change 944358 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Migrate to onPageUndeleteComplete

https://gerrit.wikimedia.org/r/944358

jsn.sherman moved this task from Code review to Done on the Moderator-Tools-Team (Kanban) board.Aug 2 2023, 7:56 PM
jsn.sherman moved this task from Code Review to Waiting for enwiki deploy on the PageTriage board.
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Aug 2 2023, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 2 2023, 8:10 PM
gerritbot added a comment.Aug 3 2023, 11:38 PM

Change 945683 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/extensions/PageTriage@master] Change WikiPage creation in onPageUndeleteComplete

https://gerrit.wikimedia.org/r/945683

gerritbot added a project: Patch-For-Review.Aug 3 2023, 11:38 PM
gerritbot added a comment.Aug 4 2023, 4:10 PM

Change 945683 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Change WikiPage creation in onPageUndeleteComplete

https://gerrit.wikimedia.org/r/945683

Maintenance_bot removed a project: Patch-For-Review.Aug 4 2023, 4:30 PM
Pppery mentioned this in T315591: Regression: Undeleted mainspace articles are not added to the PageTriage queue.Aug 22 2023, 2:32 PM
jsn.sherman closed this task as Resolved.Aug 22 2023, 5:27 PM
jsn.sherman moved this task from Waiting for enwiki deploy to Done on the PageTriage board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL